Make picking administration theme more user-friendly

Moving all usability issues to Drupal - component usability.

I am picky!

It might take a bit of rewriting of the help text, but why not make this part of the main theme page? I am envisioning something like the following screenshot:

More here: http://groups.drupal.org/node/15672

Front-end / Back-end is better :
http://www.flickr.com/photos/30032901@N04/2922043198/sizes/o/

I actually think that front-end and back-end will not be understood by non web gurus. I think that "administration theme" is more clear. You did you mention if you liked the idea of combining these into a single page. Is this the right direction?

For me, combine this two settings on the same page is more logical.

Having the administration menu setting under admin/settings never made sense to me.

#10: the idea is that hopefully we can remove the UI (not the functionality!) for enabling multiple themes from core, thus removing the need for the 'Enable' radio button.

A caroussel would only be interesting if themes have larger thumnails than what they come with now I think. Current thumbnails provided by themes are too small to warrent a view-per-item display.

#7: Yes, merging the site and administration theme settings on one page is the way to go.

Here we go! Let's get this in D7! Patch for review, but FYI we still need to figure out what to do with the 'Use administration theme for content editing' option (the 'node_admin_theme' variable). I have no idea where it should go or if we should keep it.

FYI '#default_value' => variable_get('admin_theme', 'garland') ? variable_get('admin_theme', 'garland') : variable_get('theme_default', 'garland'), is that way because on D5/6 the admin_theme variable was stored as '0' and we want to get the actual theme name.

Usability is now a tag, so removing from title

Screenshot for review.

Disclaimer: I have not looked at or tested the patch, only viewed the screenshots

The only problem that I see with this approach is a situation where you might enable an administration theme for a reason (like testing a new theme being developed) while having multiple themes enabled. Then, after testing the new theme, you want to revert to having the user's default theme as their administration theme. With radio buttons, there is no way to unselect all the radio buttons, thereby returning to the default setting.

To get around this, I see two options. The first is to have a final "user's theme" button, however this could confuse admins as it does not fit for either the enabled or default columns. The other option could be to move the existing dropdown list to be under the main theme selector, maybe in a collapsible fieldset, which would combine it on the same page as the other theme selections, and keep the current behaviour. This fieldset could then also contain the 'Use administration theme for content editing' option, as it makes no sense unless a specific administration theme is selected.

Ok, here's a different attempt from #14. Moved the admin theme to a local task tab at admin/build/theme/admin. Also converts the node admin variable to a more flexible 'admin theme paths' textarea that is easier to use. Attached screenshot as well.

The two radio button columns (Default and Admin) next to each other looks terribly. I would suggest to remove those columns from the table and make them a "select" type fields above the table.
The "Use administration theme for content editing' option" could be also above the table..

And I would also move the enabled column to the first place, as it is on page admin/settings/language

ok, I crossposted.
the #16 looks better..

Change "admin" to "administrative theme" because the word "admin" is used *nowhere* in the interface

Discussed with webchick about the options for the admin theme page:
1. Subtab at admin/build/theme/admin (like #16) but it would seem silly to have a user picking a theme without seeing the pictures (like admin/build/theme/list). But now we have two pages that are essentially the same thing.
2. An 'Administration theme' collapsed fieldset underneath the current theme selector in admin/build/theme/list. This seems to make the most sense as it keeps all the theme selection options on the same page, but keeps the admin options out of the way.

New patch w/ screenshots implementing option 2. This option is growing on me much faster than the others.

I'd like the usability team to chime in on this, but I'm cool with #21 if they say it's okay.

I like #21 over the others... but i feel there is room for improvement... (just don't know where.)

#21 looks like the way to go,

- showing the fieldset initially collapsed is ok, it's a bit of an advanced/secondary task on this page.
- on this page you'll have the thumbnails above to know what you are choosing.
- we're removing yet another /admin page, hooray!

An empty text field for additional paths to show the admin theme on is *not* easier to use though. It actually moves doing the actual work over to the user. More flexible yes, but clicking a checkbox is a lot easier and involves less thinking than looking up a path and typing it in, wildcards ("huh? what's a wildcard?") and all.

Is there a need to make this part more flexible? Should it be part of this issue? Let's keep the 'show on node/edit pages' checkbox for now and discuss the added options for admin theme in a follow up issue.

Otherwise, good work and would love to see this committed.

yoroy, you make a good point. The added flexibility of the admin theme paths textarea should be a separate patch (I bet there is an existing one out there somewhere). Here's a revised patch based on yoroy's suggestions.

I want to point you guys to http://drupal.org/node/346573 also to close the circle. These two are very related.

Yes, that would be the follow up :-)

I know I am not an UI person but I dig #12/#14.

Cant we marry the REALLY nice table based approach with the collapsed fieldset holding only the paths?

Edit: explanation, take #12/#14 , remove configure link, add collapsed fieldset with just a textarea for paths.

If someone sits down and fixes #292253: Remove the per-user themes selection from core it's possible we could revisit the UI here. But I think it's unacceptable to have two radios and a checkbox as the UI. It's already confusing enough as it is.

For now though, this patch is a dramatic improvement because it makes these settings actually findable.

However, according to http://acquia.com/files/test-results/modules_system_system.admin.inc.html we have no tests for the administration theme, so we should add some while we're touching this part of the code.

Looking through the patch I didn't see any other glaring things, and #21 has usability team +1, so as long as the tests get written I am cool with committing this.

Revised patch with tests that I might have made a little too extensive, but they cover all the admin theme stuff, including the 'Reset to defaults' button.

Wow, GREAT!!

Two quick nits on that test:

[21:25] <webchick> +    $this->drupalPost('admin/build/themes', $edit, t('Save configuration'));
[21:25]  <webchick> +    $this->assertRaw('/themes/stark/', t('Administration theme used on an administration page.'));
[21:25]  <webchick> that will match *all* themes, because it's the themes page. Better go to just 'admin' first.
[21:25]  <webchick> +    $this->drupalGet('node/' . $this->node->nid);
[21:25]  <webchick> +    $this->assertRaw('/themes/garland/minnelli/', t('Site default theme used on front page.'));
[21:25] <webchick> that assertion doesn't match what that get statement is doing

Fixed webchick's concerns and the fact that I didn't have a proper 'description' value for the test class, oops. Changed the test to not use minnelli since /themes/garland also matches the minnelli theme. So now, just using stark and garland.

We also discussed using XPath to check for the exact css files in
. But I think that is something best left for our future actual theme selection test where it should test that all the proper css files have been included properly.

(08:53:04 PM) webchick: davereid, now the only thing that's not tested here is the admin theme without the node_admin_theme => TRUE
(08:53:19 PM) davereid: webchick: Actually, the reset to defaults covers that
(08:53:34 PM) webchick: Well. No. Because it never resets node_admin_theme to FALSE.
(08:53:44 PM) webchick: It works because you've set the site theme and admin theme to be the same.

Alright, I think this test is good now. Posting for final review.

Revised because webchick is picky tonight.

Well...frak me. That's what I get for being a smarty pants.

YAY! Committed to HEAD. :) Thanks so much!

Great! Thanks Dave Reid.