It would be helpful for a webmaster to see the version of the installed plupload library in the status report.

CommentFileSizeAuthor
#4 1348892_show_library_version_4.patch4.06 KBslashrsm
#2 1348892_show_library_version_2.patch3.89 KBslashrsm
#1 add_version_to_status_report-1348892-1.patch3.46 KBMoloc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Moloc’s picture

Moloc CreditAttribution: Moloc commented
Status: Active » Needs review
FileSize
add_version_to_status_report-1348892-1.patch3.46 KB

Here is the patch, that displays the version information in the status report.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
FileSize
1348892_show_library_version_2.patch3.89 KB

I think this would be nice to have. Patch looks OK. I have made just few improvements:
- added some comments
- renamed plupload_library_path(); to _plupload_library_path(); as I see this as an internal function.

paranojik’s picture

paranojik CreditAttribution: paranojik commented
Status: Needs review » Needs work

I would add an additional check for the minimal required version and display the result appropriately.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Needs work » Needs review
FileSize
1348892_show_library_version_4.patch4.06 KB

Added this. I am using PHP's version_compare() function to check versions. See patch...

axe312’s picture

axe312 CreditAttribution: axe312 commented
Status: Needs review » Reviewed & tested by the community

Patch #4 is working correctly.

What about notifing the admin via drupal_set_message() that plupload has to be installed/updated after he installed the module?

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Reviewed & tested by the community » Fixed

Commited to 7.x-1.x: http://drupalcode.org/project/plupload.git/commit/b64ea2d

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit b64ea2d on 7.x-1.x, 7.x-2.x, 8.x-1.x by slashrsm: 
    Issue #1348892 by slashrsm,Moloc: Show library version in status report...