Cloning/Exporting Feeds Importer doesn't work with Tamper

I can see how this would be desired, but not sure if it's expected. Maybe we can add a checkbox to the clone form asking if you'd like to clone the plugins?

Other opinions?

I've just had this issue. To get around it for now I am using Features - but this is still a real big pain to be honest.

I packaged up my feed importer and its associated tamper plugins into a single feature. I then copied the feature module and all files to a feature naming convention for the cloned version. You then need to go through all the files and changed all the functions and text to cover your new feed..... This is a real pain - but still quicker than rebuilding all the tamper plugins if you have quite a few.

It would be great if this functionality could be included into the tamper module - but in the meantime this work around is fine for me.

While awaiting for patch/module/etc... I cloned the importer, then into the database here's the sql :-

INSERT INTO feeds_tamper
          ( id, importer, source, plugin_id, settings, weight, description)
     SELECT REPLACE(id, '***IMPORTER MACHINE NAME TO CLONE***', '***NEW IMPORTER MACHINE NAME***'), '***NEW IMPORTER MACHINE NAME***', source, plugin_id, settings, weight, description
      FROM feeds_tamper WHERE importer = '***IMPORTER MACHINE NAME TO CLONE***';

For everyone's information, there's a new module that provides cloning for Feeds Tamper: http://drupal.org/sandbox/mamanerd/1906440

Hey everyone, here's a patch that will allow you to clone tamper plugins when cloning a feeds importer. I originally made it into a separate module, but realized that was not really necessary. Let me know if you have any issues!

Setting this to "needs review" so that the patch gets reviewed.

Attempting to submit patch again..

Can someone help me figure out why my patch keeps failing? It applies cleanly when I try to apply it to the 7.x-1.x branch locally. Any ideas?

Thanks for the info, module in #6 works flawlessly!

phew, lots of time saved

@mamanerd You have to change the version on the issue so the testbot knows which version to apply the patch to.

#10: feeds_tamper-clone_tamper_plugins-1346936-10.patch queued for re-testing.

Patch has error:

Fatal error: Call to undefined function feeds_tamper_clone_clone_tamper_plugins() in /home/chris/www/taymor/includes/form.inc on line 1464

RE-roll attached.

Ok #16 works as designed and is pretty useful! Code looks good too

I can also confirm #16 works as announced. Code looks simple and clean.

I consider this feature is so basic and expected that i dare to ries priority. Feel fre to rearrange that.

This is awesome!

1. +++ b/feeds_tamper_ui/feeds_tamper_ui.module
   @@ -139,3 +139,64 @@ function feeds_tamper_ui_source_name(stdClass $instance) {
   +    // Let's get the #from_importer ID.
   +    $from_importer_id = isset($form['#from_importer']->fetcher->id) ? $form['#from_importer']->fetcher->id : '';
   

   This can just use $form['#from_importer']->id.

2. +++ b/feeds_tamper_ui/feeds_tamper_ui.module
   @@ -139,3 +139,64 @@ function feeds_tamper_ui_source_name(stdClass $instance) {
   +    if ($from_importer_id) {
   +      $tamper_plugins = feeds_tamper_load_by_importer($from_importer_id, FALSE);
   +    }
   

   So then $tamper_plugins can be undefined?

3. +++ b/feeds_tamper_ui/feeds_tamper_ui.module
   @@ -139,3 +139,64 @@ function feeds_tamper_ui_source_name(stdClass $instance) {
   +    foreach ($tamper_plugins as $tamper_plugin) {
   +      foreach ($tamper_plugin as $old_instance) {
   

   Need different names for these variables.

4. +++ b/feeds_tamper_ui/feeds_tamper_ui.module
   @@ -139,3 +139,64 @@ function feeds_tamper_ui_source_name(stdClass $instance) {
   +        $new_instance = feeds_tamper_new_instance();
   +        $new_instance = $old_instance;
   

   Why call feeds_tamper_new_instance() then overwrite it with the old instance. We should just clone $old_instance.

5. +++ b/feeds_tamper_ui/feeds_tamper_ui.module
   @@ -139,3 +139,64 @@ function feeds_tamper_ui_source_name(stdClass $instance) {
   +        $new_instance->id = str_replace($from_importer_id, $form_state['values']['id'], $new_instance->id);
   

   stre_replace() isn't safe to use here. Should use explode('-', $id, 2).

6. +++ b/feeds_tamper_ui/feeds_tamper_ui.module
   @@ -139,3 +139,64 @@ function feeds_tamper_ui_source_name(stdClass $instance) {
   +        $new_instance->export_type = NULL;
   

   Isn't there a constant for this?

7. +++ b/feeds_tamper_ui/feeds_tamper_ui.module
   @@ -139,3 +139,64 @@ function feeds_tamper_ui_source_name(stdClass $instance) {
   +        unset($new_instance->disabled);
   

   Should disabled plugins stay disabled?

Hi,

#16 works for me with the current stable version 7.x-1.0.

Thanks,
great feature that makes life more easy!

#16 works with latest dev version 7.x-1.x-dev. Thanks!

Also, check this out #2381487: Features: Automatically add Tamper plugins when a Feed Importer is selected.