Index queries with multiple-valued parameters don't seem to be handled correctly in 6.x-3.x. An example query would be endpoint/user.json?parameters[uid]=1,2,3,4. The attached patch fixes this issue, though it needs vetting and testing.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | mulitvalue-index-d6-1341702-4.patch | 5.57 KB | cotto |
| #4 | multivalue-with-test-d6.patch | 4.94 KB | marcingy |
| #3 | multivalue-with-test.patch | 2.13 KB | marcingy |
| #2 | mulitvalue-index-d6-1341702-2.patch | 1.91 KB | cotto |
| #2 | mulitvalue-index-d7-1341702-2.patch | 509 bytes | cotto |
Comments
Comment #1
marcingy commentedFrom reading the 7.x code we have a similar issue there.
Comment #2
cotto commentedHere's a simpler version that uses the
x IN (...)syntax for all queries so that there's only one control-flow path. The d6 version seems to work. The d7 version is my best guess and hasn't been tested.Comment #3
marcingy commentedD7 version with test
Comment #4
marcingy commentedD6 patch with tests
Comment #5
cotto commentedIt looks like I left out a line from the previous patch. With the attached patch, there are no new test failures in 6.x-3.x. If everyone's happy with the code, the patch is ready to commit.
Comment #6
marcingy commentedI'm happy with the code in both but can't rbtc as I wrote the tests.
Comment #7
ygerasimov commentedI am happy with patches #3 and #5
Comment #8
kylebrowning commentedTested these this morning, looks good.
Comment #9
kylebrowning commented