We have this issue filed against the treeTable JavaScript library to add support for ajax on-demand loading of children of parent rows. It would be good if we could have people help by cloning that Github project and providing a pull request to support jQuery ajax loading for children.


#25 token-n1334456-25.patch15.19 KBDamienMcKenna
PASSED: [[SimpleTest]]: [MySQL] 347 pass(es).
[ View ]


Dave Reid’s picture

I had to cut my losses and roll a 7.x-1.0 release without this issue. It is still considered a big priority to fix, hopefully in a 7.x-1.1 or 7.x-1.2 release.

santam’s picture

Interstingly I used to receive out of memory errors earlier which had disappeared with the previous two versions of the module but have now reappeared again. Have there been any significant changes made?

reptilex’s picture

Autonode Title is useless due to this issue when entity references are being used on a node. I get a WSOD with a memory exhausted error. Until this issue is resolved token_tweaks works great.

Dave Reid’s picture

@reptilex: If you don't have anything constructive to add, you can use the big green 'Follow' button near the top-right of this issue rather than adding an unhelpful comment.

sarvab’s picture

new205.32 KB

I threw together something for ajax lazy-loading using the jsTree jquery plugin (http://www.jstree.com/) instead of tabletree. I went with jsTree instead of tabletree since my goal was to get something up and working as-simply and as-quick as possible while jsTree provided both 1) tree-like functionality and 2) json ajax leaf support.

Currently missing with this patch (that I can think of) is 1) No JS support and 2) Descriptions for each token

Given the above I wouldn't be sure if jsTree is suitable in the long run, but it is working great for me and eliminates all recursive/memory issues as well so hoping it can be of use to others and maybe help push the issue along.

klonos’s picture

Great job Sarva! I wasn't aware of jsTree and it does look very promising from a quick look at its feature list (+ it seems more polished from the screenshots available in its home page). Besides the fact that it already offers AJAX loading, it also includes a search functionality that I saw being suggested as a feature someplace, ...I think in #514990: Add a UI for browsing tokens.

moonray’s picture

Status:Active» Needs work

Updating to reflect status.

Devin Carlson’s picture

andypost’s picture

It looks terrible that token-tree is rendered as table, suppose better to convert this to ul>li or dl>dt-dd

Sk8erPeter’s picture

@andypost: why would it be a better solution? And how would this token tree look like a table if it wasn't rendered as a table? :) I think the table structure is justifiable: it's needed, because there's a "Name", "Token" and "Description" column. What needs to be changed is that tokens list should be displayed on-demand: #1842738: Provide admin setting to replace all uses of the core token browser with the new popup.

moonray’s picture

This is even more heavily needed after the 7.x-1.5 update. See #1954464: Memory Issue

hefox’s picture

It sounds like ajax loading has been added via that linked issue

Dave Reid’s picture

Correct. Who wants to work on bringing in those changes to token so that we can utilize them?

mattsmith3’s picture

Confirming the issue here. It's notable that when using filefield_paths this actually hosed a site- to the point that I couldn't load any pages with tokens at all. Token Tweaks is helping a bit- but not seeing the full list of tokens isn't a solution (in my humble opinion)... kind of defeats the purpose.

Perhaps a patch to disable the ajax/js on this page (or token lists) and simply list all the tokens is a temporary solution?

mattsmith3’s picture

Priority:Major» Critical

This issue is also breaking flags on my install, which is a large site with many, many fields. I can now only use the site with the token tweaks module. Upgrading to critical.

What needs to be done to fix this? I might try a start with some more direction.

TBarina’s picture

Any progress here?
I'm still facing the issue.

UPDATE: I've installed patch #5 and seems to work well! Many thanks for this great job!

DamienMcKenna’s picture

Closed a duplicate: #1954464: Memory Issue

DamienMcKenna’s picture

The patch in #5 does not apply to either the latest -dev release or the latest stable release.

DamienMcKenna’s picture

Issue summary:View changes
Status:Needs work» Needs review
new205.18 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in token-n1334456-19.patch.
[ View ]

This is a simple reroll of #5 for the latest -dev release.

Status:Needs review» Needs work

The last submitted patch, 19: token-n1334456-19.patch, failed testing.

DamienMcKenna’s picture

I've tested the patch a but it fails with the following 404 errors:

[Error] Failed to load resource: the server responded with a status of 404 (Not Found) (style.css, line 0)
[Error] Failed to load resource: the server responded with a status of 404 (Not Found) (d.png, line 0)
Anybody’s picture

The problem still exists and is still highly critical because it kills messy IE. How can we proceed here?

deanflory’s picture

Just posting this question here: Are there working patches out there on the various issues involving the token browser that allow replacing the trees with an AJAX browser or a link to a popup AJAX browser?

I've found 8 or so issues related to this and am just trying to make sure I'm not missing a "fix" out there that I haven't come across yet.

Dave Reid’s picture

No, there has not been a true fix yet.

DamienMcKenna’s picture

Status:Needs work» Needs review
new15.19 KB
PASSED: [[SimpleTest]]: [MySQL] 347 pass(es).
[ View ]