The images on the Galleries page are huge. There is only one column, with width=100%.
The Problem:
media_gallery uses hook_menu_alter() to modify the taxonomy/term/%term path callback function to build the Galleries page. Other modules are also overwriting this path callback and therefore specific gallery settings/styles can not be applied.
Known modules, which overwrite/conflict with media_gallery:
- i18n_taxonomy (Taxonomy translation)
- taxonomy_display #1811860: Support taxonomy_display module to prevent page callback overwriting
- page_manager (Chaos tool suite (ctools))
Related issues:
#1168358: taxonomy/term menu alter
#1301160: Media gallery breaks taxonomy panels
#1231170: Taxonomy translation (i18n) breaks display of gallery-collections page + missing some code
#1047970: Conflict with i18n_taxonomy: Gallery thumbnails stretch to full width of content area
Original Issue:
The images for the galleries are HUGE on the main page. Is this something I can change?
Comment | File | Size | Author |
---|---|---|---|
#20 | 1333674-conflicts-20.patch | 12.08 KB | guillaumev |
#16 | 1333674-conflicts-16.patch | 11.68 KB | guillaumev |
Comments
Comment #1
Moloc CreditAttribution: Moloc commentedThe size of the thumbnails depends on the count of columns you define in the gallery setting. Increase the column-value and the images should be smaller.
Comment #2
Useful Idiot CreditAttribution: Useful Idiot commentedInitially that worked for me, but now I am having the same issue. I have it set for 3 columns and 6 rows and it still is displaying only 1 column of large images. Please advise.
Comment #3
Moloc CreditAttribution: Moloc commentedWhat does "initially that worked for me" means? You had that problem and got rid of it by changing the columns. And now you have the problem again?
Does this issue occur on the "All Galleries" page?
Does this issue occur on a gallery node (viewing the media of the gallery)?
- Does this issue exist only, if the gallery is full (adding a new media will show the pager), or also, when there are only -for example- 2 images?
(Or does it occur on both: All Galleries and gallery-node?)
Do you have a public installation, where this error can be seen?
Comment #4
Useful Idiot CreditAttribution: Useful Idiot commentedHi Moloc, thanks for the speedy reply.
Sorry for my vague response.
I had the module installed and running properly. My main gallery page had 3 columns and 3 rows. Now my main gallery page is only showing 1 column no matter what I put the settings on. It seems the gallery nodes are still functioning properly , only the main gallery page that seems to have the issue. I only have 2 albums for now, so there was still room on the right side of the first row for another thumbnail when it was working.
I have a public install but it is under construction and in maintenance mode. If you'd like access I have no problem giving it to you. Just let me know. Thanks for the ultra-quick response.
Cheers!
Comment #5
Moloc CreditAttribution: Moloc commentedWhich theme are you using? There seems to be a problem with some themes. See #1301374: Galleries no longer showing in columns & rows and #1230090: .media-gallery-detail img should not have width 100%.
Comment #6
Useful Idiot CreditAttribution: Useful Idiot commentedThanks for the links, seems to be an issue with adaptive themes. I'm using the most current version of corporate clean.
Comment #7
Moloc CreditAttribution: Moloc commentedI got the html-source from Useful Idiot and it seems, that the function media_gallery_list_galleries is not executed (you can see that on the missing html-elements, added by the theme media_gallery_collection function.
Now i am able to reproduce this bug. The submodule Taxonomy translation of the Internationalization module breaks the view.
Looking at the source code, we can find the following lines in media gellary:
The Taxonomy translation module uses the same hook and overrides the page callback. Therefore the galleries are shown in a wrong way on the "all galleries" page. So every module, overriding this lines may break the view too.
Solution: Maybe someone have a look on hook_entity_info_alter(), as described in the TODO statement.
Comment #8
Moloc CreditAttribution: Moloc commentedAs reported in #7, there are more modules, which conflict with media_gallery by using hook_menu_alter().
- i18n_taxonomy (Taxonomy translation)
- taxonomy_display
- page_manager (Chaos tool suite (ctools))
Related issues:
#1168358: taxonomy/term menu alter
#1301160: Media gallery breaks taxonomy panels
#1231170: Taxonomy translation (i18n) breaks display of gallery-collections page + missing some code
#1047970: Conflict with i18n_taxonomy: Gallery thumbnails stretch to full width of content area
#1224906: "Gallery" content types not displaying all fields, and collection thumbs too large in teasers...
Comment #9
NexusStar CreditAttribution: NexusStar commentedI encounter the same problem with Views when enabled default taxonomy view it breaks the gallery output.
It happens because it overrides the HTML
here is the default output:
and here is the changed one
as you can see there is no wrapping div with classes (mg-col mg-col-4) that defines the columns anymore that way it all went on one column
Comment #10
lsolesen CreditAttribution: lsolesen commentedComment #11
lsolesen CreditAttribution: lsolesen commentedIn #1231170: Taxonomy translation (i18n) breaks display of gallery-collections page + missing some code a module has been posted that supposedly solves the problem. Should probably be reviewed.
Comment #12
lsolesen CreditAttribution: lsolesen commented@Moloc - do you have any idea on a safer way to get the callback in #7 executed.
Comment #13
Moloc CreditAttribution: Moloc commentedThe patch, mentioned in #11 does not fix the issue (it just overwrites the callback and mixes i18n and media_gallery code together).
#12 No. I investigated some time with no solution. I read the entity api, but was not able to find a useable way to set a callback function.
Comment #14
dimitriseng CreditAttribution: dimitriseng commented@Moloc, I am using the custom module mentioned in #11 and it is fixing the issue, but I agree that the way it does it might not be correct. From your comments in #13 it looks like you do not think that there is an easy way to resolve this. However, I think that this is very important for multilingual sites and that it will hopefully get resolved soon.
@all, anybody has any ideas? Thank you.
Comment #15
guillaumev CreditAttribution: guillaumev commentedI think the way to fix this issue is to try to use a view for the main media gallery page instead of having a custom callback. I'm currently working on a patch going in this direction...
Comment #16
guillaumev CreditAttribution: guillaumev commentedHere is a first patch. I removed the alias and menu in the install file because I don't think it should be the role of the media gallery module to define that...
This is a first shot for the view, and I'm sure there are lots of improvements that can be done on it...
Comment #17
lsolesen CreditAttribution: lsolesen commentedComment #18
lsolesen CreditAttribution: lsolesen commentedI agree that having that page as a view will be the best solution. The patch seems to work. Have the following comments.
- uses the same url as the existing one, and thus it will not show the view when just applying the patch on an existing install. The patch should probably include a fix for that?
- it is not possible to alter the galleries link on admin/config/media/galleries to change that? Should that be included in the patch?
- the view uses the teaser view. Should it use fields instead?
- could it still be easy for the end user to alter the rows and columns from a central settings page instead of having to go to views?
- should the removal of the alias and menu in the install file be a separate issue?
What is your opinion?
Comment #19
lsolesen CreditAttribution: lsolesen commentedTagging
Comment #20
guillaumev CreditAttribution: guillaumev commentedIsolesen > I'll try to work on a patch that includes the points posted in comment #18 when I have a bit more time. Meanwhile, here is the same patch as in comment #16, but that applies to the latest version of media_gallery.
Comment #21
lsolesen CreditAttribution: lsolesen commented@Moloc What is your take on this issue?
Comment #22
Moloc CreditAttribution: Moloc commentedIt would be nice to use views - if it is possible. I think, this needs some more tests. There are some open questions:
- We need a dependency to views. (currently not in the patch)
- Does this solution work with the modules mentioned in #8?
- Does this solution work with multiple gallery collections? #1037002: New feature: Gallery containers
- If the users change the sorting of the galleries, will our drag-drop ordering still work? What do we have to change in this situation?
Comment #23
c0ldfury CreditAttribution: c0ldfury commentedThe global settings no longer work with the patch (obviously) so can be removed, or linked to the view settings somehow.
Title on hover isn't working with the view either, although I'd imagine some custom CSS on the view fields will fix that.
Multiple galleries can be dealt with via an exposed filter on gallery collection field.
The patch certainly fixes the issue with ctools pages though, thanks.
Comment #24
lsolesen CreditAttribution: lsolesen commentedMarked #1686498: Media gallery overrides taxonomy/term/%taxonomy_term, breaking overrides in Views and Pages as duplicate.
Comment #25
lsolesen CreditAttribution: lsolesen commentedComment #26
caspercash CreditAttribution: caspercash commentedI am using the 7.x-1.0-beta8 version of media_gallery and this issue still exists. Also the drag and drop functionality isn't working in the 'All Galleries' page but it works fine in the individual galleries. Any updates? Thanks for this great module!
Comment #27
lsolesen CreditAttribution: lsolesen commentedDrag'n'drop is a different issue. Please look in the issue queue about that one. Also this issue is scheduled for a later release - look at the Roadmap. You are more than welcome to supply a patch which solves the problem.
Comment #27.0
Moloc CreditAttribution: Moloc commentedUpdate summary to describe the issue and the problem/conflict with other modules.
Comment #28
mtndan CreditAttribution: mtndan commentedHi, the patch works great for the main Galleries view.
Should it also work for any user-created galleries? I'm still seeing the same issues.
Thanks
Comment #29
pinkonomy CreditAttribution: pinkonomy commentedAny news on this?
Comment #30
pinkonomy CreditAttribution: pinkonomy commentedI still have this issue for Media Gallery version 2 dev.
thanks
Comment #31
pauleb CreditAttribution: pauleb commentedThis is way beyond my scope and I didn't test the 2.x branch but as far as the road map for media gallery and the tag on this issue show it will be addressed when working on 1.0-beta10. At least that's my interpretation.
Comment #32
Carlos Miranda Levy CreditAttribution: Carlos Miranda Levy commentedAdministration Views will also clash with media gallery and generate big thumbnails. If you disable it, you still need to disable created views as well to return to small thumbnails and Edit All Galleries tab.
Comment #32.0
Carlos Miranda Levy CreditAttribution: Carlos Miranda Levy commentedAdded taxonomy_display issue
Comment #33
pinkonomy CreditAttribution: pinkonomy commentedWhat should be done so as to integrate the patch with panels?
Comment #34
saltednutI don't know if it is in scope to deal with this in the 1.x branch for the work I am currently doing. For now, I'd like to see about dealing with it in the 2.x branch.
I don't believe changing this to a View is a great idea, as it adds an additional dependency. It does make sense to me to make this a standard page callback.
I will see about working out a patch for 2.x that solves this. Once this is resolved for 2.x we can kick this back to 1.x for backporting.
Comment #35
mrfelton CreditAttribution: mrfelton commentedComment #36
vulfox CreditAttribution: vulfox commentedWhat is the current status?
Comment #37
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedWSOD is created because of this line because the patch deletes function media_gallery_list_galleries
media_gallery/plugins/content_types/gallery_list.inc:36: $block->content = media_gallery_list_galleries($context->data);
Comment #38
pj4ever CreditAttribution: pj4ever commentedApplied this hotfix and deleted function media_gallery_list_galleries. how to get this function back?
Warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'media_gallery_list_galleries' not found or invalid function name in menu_execute_active_handler() (line 519 of /homepages/39/ddda/htdocs/clickandbuilds/Drupal/sitename/includes/menu.inc).
Comment #39
loudpixels CreditAttribution: loudpixels as a volunteer commentedAny resolve on this issue? Thanks!
Comment #40
loudpixels CreditAttribution: loudpixels as a volunteer commentedI was able to hack my way with CSS ... I basically enabled the "taxonomy display" module and re-crafted my main "media gallery" page with CSS. I did loose all the features like drag'n drop re-ordering and the small text indicateur of the number of images/videos within each gallery, . If anyone is interest in my CSS code I can post it here.
I'll keep an eye and see if there's an official fix. Thanks!
Comment #41
orangutangle CreditAttribution: orangutangle commentedA quick CSS hack which will prevent the gallery thumbnail displaying at width 100%:
Add to your theme CSS.
[Edit] Uggh, sorry this solution is not responsive.
Comment #42
ivnish CreditAttribution: ivnish commented