Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Usually iconv is already on most systems(i.e. debian default libapache2-mod-php5 package), but a check on hook_requirements()
would be great to have, specially now that we directly rely on it: #1078392: Manage incorrect/mismatched string encoding gracefully.
Comment | File | Size | Author |
---|---|---|---|
#5 | versioncontrol_git-iconv_check-1331352-5.patch | 1.71 KB | tizzo |
#4 | versioncontrol_git-iconv_check-1331352-4.patch | 1.71 KB | tizzo |
#3 | versioncontrol_git-iconv_check-1331352-3.patch | 1.74 KB | tizzo |
Comments
Comment #1
sdboyer CreditAttribution: sdboyer commentedyeah, definitely need to add this.
Comment #2
tizzo CreditAttribution: tizzo commentedTaking this on.
Comment #3
tizzo CreditAttribution: tizzo commentedComment #4
tizzo CreditAttribution: tizzo commentedFixing comment to be appropriate to both passes and fails.
Comment #5
tizzo CreditAttribution: tizzo commentedDropping period to be more consistent with other messages. I think I'm really done now.
Comment #6
marvil07 CreditAttribution: marvil07 commentedThanks for the patch!
Added to the 7.x-1.x branch. I guess it will be on 6.x-2.x after #1699696: Backport git version check on hook_requirements