Usually iconv is already on most systems(i.e. debian default libapache2-mod-php5 package), but a check on hook_requirements() would be great to have, specially now that we directly rely on it: #1078392: Manage incorrect/mismatched string encoding gracefully.

CommentFileSizeAuthor
#5 versioncontrol_git-iconv_check-1331352-5.patch1.71 KBtizzo
#4 versioncontrol_git-iconv_check-1331352-4.patch1.71 KBtizzo
#3 versioncontrol_git-iconv_check-1331352-3.patch1.74 KBtizzo

Comments

sdboyer’s picture

sdboyer commented
Issue tags: +versioncontrol_git-6.x-2.0-release-blocker

yeah, definitely need to add this.

tizzo’s picture

tizzo commented
Assigned: Unassigned » tizzo

Taking this on.

tizzo’s picture

tizzo commented
Status: Active » Needs review
StatusFileSize
new versioncontrol_git-iconv_check-1331352-3.patch1.74 KB
tizzo’s picture

tizzo commented
StatusFileSize
new versioncontrol_git-iconv_check-1331352-4.patch1.71 KB

Fixing comment to be appropriate to both passes and fails.

tizzo’s picture

tizzo commented
StatusFileSize
new versioncontrol_git-iconv_check-1331352-5.patch1.71 KB

Dropping period to be more consistent with other messages. I think I'm really done now.

marvil07’s picture

marvil07 commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed

Thanks for the patch!

Added to the 7.x-1.x branch. I guess it will be on 6.x-2.x after #1699696: Backport git version check on hook_requirements

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit c9986d9 on 7.x-1.x, fix-invalid-default-branches, fullsync-memory authored by tizzo, committed by marvil07: 
    Issue #1331352 by tizzo: Add iconv check.