The message 'You must check manually that this role has the appropriate transition permissions for your workflow. View moderation permissions for this role.' contains a link to admin/config/workbench/moderation/@moderation_permission_link

CommentFileSizeAuthor
#3 broken_link-1329606-3.patch4.21 KBadammalone
#1 broken_link-1329606-1.patch1.12 KBstevector

Comments

stevector’s picture

stevector
he/him
commented
Version: 7.x-1.0-beta8 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new broken_link-1329606-1.patch1.12 KB

small fix.

JacobSingh’s picture

JacobSingh commented
Status: Needs review » Reviewed & tested by the community

Pretty obvious bug and fix.

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented
Title: broken link in admin message » broken link in admin message - patch attached
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new broken_link-1329606-3.patch4.21 KB

As an addition to this I've gone through the admin interface and changed all those links from url() to use l(). I've removed all the html from the links so it's handled by the l() function.

Status: Needs review » Needs work

The last submitted patch, broken_link-1329606-3.patch, failed testing.

joachim’s picture

joachim commented

> changed all those links from url() to use l().

That's an incorrect use of t(), because it breaks up the human-read text and makes it impossible to translate. The docs on t() explain this http://api.drupal.org/api/drupal/includes!bootstrap.inc/function/t/7.

Patch at 1 is still RTBC I assume?

amanire’s picture

amanire commented
Status: Needs work » Reviewed & tested by the community

Patch in #1 was recreated in a duplicate issue: http://drupal.org/node/1808698

It's trivial and should be rolled into dev.

hass’s picture

hass commented

@typhonius: #3 is an incorrect change. url() is correct! If you have such bugs in any of your modules, please fix them.

hass’s picture

hass commented

Patch in #1 is RTBC.

stevector’s picture

stevector
he/him
commented
Status: Reviewed & tested by the community » Fixed

Committed http://drupalcode.org/project/workbench_moderation.git/commitdiff/ff84d9...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.