From #1318374: Refactor code layout of classes using autoloader omega8cc:

There are major bugs introduced in the SSL templates, where you still have old, no longer existing paths like include('http/apache/vhost.tpl.php');

Comments

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented

Thanks for testing!

Because of the new autoloader I wonder if we need some sort of helper function to get the location of a where a particular class is defined so we can change:

include('http/apache/server.tpl.php');

into:

include(class_directory('Provision_Config_Apache_Server') . '/server.tpl.php');

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented
Status: Active » Needs review

I've popped a fix into 6.x-2.x, lets see what Jenkins thinks, and will need manual testing too.

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented

I have tried to review this, but failed early with #1333710: Autoloader doesn't work in PHP 5.2.

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented
Status: Needs review » Reviewed & tested by the community

Tested with Nginx and it works fine. Thanks!

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit a674ddb on 6.x-2.x, dev/1318374-autoloader, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by Steven Jones: 
    Issue #1329000 by Steven Jones: Fixed SSL Templates are broken.