First of all, excuse my English.

If Taxonomy Image integration is on, then one more column (sixth) is added to the forum table, but number of columns in the table header remains the same (five). Because of it all captions shifted to wrong column. You can see results on attached screenshots.

CommentFileSizeAuthor
#4 table_header_colspan_for_taxonomy_image-1328152.patch952 bytesmcdruid
taxonomy_image_on.gif5.98 KBRedRat
taxonomy_image_off.gif5.67 KBRedRat

Comments

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Hmm... I'm pretty sure this was fixed at one point. I remember the patch. Don't have time to test to see if it got reverted somehow, though.

Michelle

mcdruid’s picture

mcdruid commented

I think this is probably the issue / patch you're thinking of Michelle: #1015118: naked style colspan bug with taxonomy_image module enabled

...however it looks like advanced_forum.naked.forum-list.tpl.php has changed a bit since then.

I'll have a proper look when I'm on my dev machine.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Yeah, that's the one I'm thinking of.

Michelle

mcdruid’s picture

mcdruid commented
StatusFileSize
new table_header_colspan_for_taxonomy_image-1328152.patch952 bytes

RedRat, could you try this patch please?

RedRat’s picture

RedRat commented
Status: Active » Reviewed & tested by the community

I have tried patch from #4 and it works fine. Just a little suggestion for it:

<th class="forum-icon"<?php if ($use_taxonomy_image) print ' colspan="2"'; ?>>

RedRat’s picture

RedRat commented

BTW, is taxonomy icons have to be added to original forum icons, or have to replace them? Now I see two icons for every forum, one from original forum theme and another from taxonomy.

mcdruid’s picture

mcdruid commented

Thanks for testing RedRat, and yes your suggestion looks like it would work fine - I was trying to stay consistent with the code which does something similar a few lines further down in the same file.

I'll get the fix committed shortly.

As for removing the default icons, there are a few support requests about that in the queue - try searching for 'taxonomy image'.

e.g. #1221444: How to change category pictures like Coulee Region forums

mcdruid’s picture

mcdruid commented
Status: Reviewed & tested by the community » Fixed

Committed to 6.x-2.x

http://drupalcode.org/project/advanced_forum.git/commit/6b0ebe3

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.