Cache url() [#1327720]

Comment	File	Size	Author
#11	drupal-cache-url-1327720-11.patch	4.49 KB	mikeytown2

#9	drupal-cache-url-1327720-9.patch	4.41 KB	mikeytown2

#7	drupal-cache-url-1327720-7.patch	4.33 KB	mikeytown2

#5	drupal-cache-url-1327720-5.patch	4.41 KB	mikeytown2

#3	drupal-cache-url-1327720-3.patch	4.41 KB	mikeytown2

#2	drupal-cache-url-1327720-2.patch	4.38 KB	mikeytown2

#1	drupal-cache-url-1327720-1.patch	4.3 KB	mikeytown2

Comment #1

mikeytown2 CreditAttribution: mikeytown2 commented 31 October 2011 at 21:40

Status:

Active

» Needs review

File	Size
drupal-cache-url-1327720-1.patch	4.3 KB

The late_cache_set_merge_locked function should be moved to cache.inc most likely; but its in here for now.

Log in or register to post comments

Comment #2

mikeytown2 CreditAttribution: mikeytown2 commented 31 October 2011 at 21:52

File	Size
drupal-cache-url-1327720-2.patch	4.38 KB

Slight efficiency improvements.

Log in or register to post comments

Comment #2.0

mikeytown2 CreditAttribution: mikeytown2 commented 31 October 2011 at 22:02

Issue summary:

View changes

Updated issue summary.

Log in or register to post comments

Comment #3

mikeytown2 CreditAttribution: mikeytown2 commented 31 October 2011 at 22:28

File	Size
drupal-cache-url-1327720-3.patch	4.41 KB

forgot to release the lock

Log in or register to post comments

Comment #4

1 November 2011 at 00:46

Status:

Needs review

» Needs work

The last submitted patch, drupal-cache-url-1327720-3.patch, failed testing.

Log in or register to post comments

File	Size
drupal-cache-url-1327720-5.patch	4.41 KB

Comment #6

1 November 2011 at 01:48

Status:

Needs review

» Needs work

The last submitted patch, drupal-cache-url-1327720-5.patch, failed testing.

Log in or register to post comments

File	Size
drupal-cache-url-1327720-7.patch	4.33 KB

Comment #8

1 November 2011 at 02:38

Status:

Needs review

» Needs work

The last submitted patch, drupal-cache-url-1327720-7.patch, failed testing.

Log in or register to post comments

File	Size
drupal-cache-url-1327720-9.patch	4.41 KB

Comment #10

1 November 2011 at 03:36

Status:

Needs review

» Needs work

The last submitted patch, drupal-cache-url-1327720-9.patch, failed testing.

Log in or register to post comments

File	Size
drupal-cache-url-1327720-11.patch	4.49 KB

Comment #12

vasrush CreditAttribution: vasrush commented 1 February 2012 at 15:31

#11: drupal-cache-url-1327720-11.patch queued for re-testing.

Log in or register to post comments

Comment #13

rjbrown99 CreditAttribution: rjbrown99 commented 11 February 2012 at 20:40

There is a report that #11 breaks Open Atrium menus. I do not know if this is an OA problem or an issue with the patch, but it's worth mentioning here.

Log in or register to post comments

Comment #14

mikeytown2 CreditAttribution: mikeytown2 commented 15 February 2012 at 23:55

Status:

Needs review

» Needs work

Too many reports of this causing issues.
lock_acquire() is taking too long. If it didn't have a while loop, it might be viable. See memcache version of lock_acquire() for some ideas to move this forward.

Log in or register to post comments

Comment #15

mikeytown2 CreditAttribution: mikeytown2 commented 1 October 2012 at 19:35

Found a patch where someone is caching below this at the url_alias level for taxonomy terms.
http://groups.drupal.org/node/97794#comment-828593

Log in or register to post comments

Comment #16

jcisio CreditAttribution: jcisio commented 16 November 2012 at 08:38

Version:

6.x-dev

» 8.x-dev

D8 first? custom_url_rewrite_outbound() (or hook_url_outbound_alter()) result is cacheable? I think we should bypass the cache in case there is a hook implementation.