Having the "clone.module" in the "node_clone" project breaks build processes...

rob@Computron /var/www $ drush make drupalbin-profile/drupalbin.make drupalbin
Project information for drupal retrieved.                                    [ok]
Project information for drupalbin_feature retrieved.                         [ok]
drupal downloaded from                                                       [ok]
http://ftp.drupal.org/files/projects/drupal-7.8.tar.gz.
drupalbin_feature downloaded from                                            [ok]
http://ftp.drupal.org/files/projects/drupalbin_feature-7.x-1.x-dev.tar.gz.
Found makefile: drupalbin_feature.make                                       [ok]
Project information for geshifilter retrieved.                               [ok]
Project information for features retrieved.                                  [ok]
Project information for pathauto retrieved.                                  [ok]
Project information for strongarm retrieved.                                 [ok]
Non-existent project type  on project node_clone                             [error]

Should we move this over to http://drupal.org/project/clone ?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RobLoach’s picture

Status: Active » Fixed

Seems to have fixed itself... Should we move the project over sometime though? Maybe when we switch to cloning Entities?

brianV’s picture

Status: Fixed » Active

Not fixed - latest 7.x dev release still contains the 'clone' module:

bv2011@domU-12-31-39-06-B9-43:/persistant/esource/drupal$ drush dl node_clone-7.x-1.x
Install location <snip>/drupal/sites/all/modules/node_clone already exists. Do you want to overwrite it? (y/n): y
Project node_clone (7.x-1.x-dev) downloaded to /persistant/esource/drupal/sites/all/modules/node_clone.                                                                                                                           [success]
Project node_clone contains a module named clone.
pwolanin’s picture

Status: Active » Closed (works as designed)
jorges’s picture

Issue summary: View changes

I am using the Features module, have created my_features_module where node_clone is a dependency for it.

In my_features_module.info, this dependency is automatically written by Features as

dependencies[] = clone

Now, when I try to install my_features_module (with Drush), I receive the following message:
Module my_features_module cannot be enabled because it depends on the following modules which could not be found: clone

I guess, this is caused by the inconsistency "node_clone" vs. "clone" described above, am I right?

If yes (also if not), how can I fix the problem?

I am also confused by Comment 3 stating that this "(works as designed)". Is that really the case?

lolandese’s picture

Priority: Critical » Major
Status: Closed (works as designed) » Needs review
FileSize
26.85 KB

Attached patch replaces all relevant instances of 'clone_' with 'node_clone_'. It has been done in several search/replace cycles. For what I remember:
' clone_'
'"clone_'
'(clone_'
'%clone_'
'>clone_'
' _clone_'

Furthermore the file names have also been changed accordingly. Some references to 'node_clone.views.inc' needed to be altered manually. Unchanged is the file name 'views_handler_field_node_link_clone.inc'.

I tested locally and it seems to work as before. Just to be scrupulous, uninstall the module first, remove it, git clone the latest version and apply the patch.

Test further on http://simplytest.me/project/node_clone/7.x-1.x?patch[]=https://www.drup... (when it is back up).

Thanks.

lolandese’s picture

FileSize
52.01 KB

Better.

lolandese’s picture

FileSize
52.59 KB
lolandese’s picture

The previous patch completely neglected Views, Actions and Rules integration. Corrected.

The new test link:
http://simplytest.me/project/node_clone/7.x-1.x?add[0]=ctools&add[1]=vie...

lolandese’s picture

pwolanin’s picture

Thanks, but changing the module name mid-release would be rather disruptive.

zarabatana’s picture

Status: Needs review » Reviewed & tested by the community

The following works as expected:

  • Cloning of content.
  • The configuration page and it's settings.
  • The 'Clone link' in Views.
  • The event 'After cloning a node' in Rules.
  • The action 'Clone a node' in Rules.

Committing this patch would solve various issues mainly experienced by Drush users and those that try to integrate this module in a distribution (Make file). I do understand some worries about breaking the two provided API functions, but no other contributed modules seem to use them. I don't see other ways the change could be disruptive, rather than fixing things to the way they should be.

Digging in a bit further I was surprised that nowhere in the Coding Standard is specified the project URL should match the project filenames and hook invocations. It is recommended by other sources that by the way also recommend to avoid underscores in project names.

hansfn’s picture

Thanks, but changing the module name mid-release would be rather disruptive.

Sure, but the current situation is really bad. I hope this patch gets committed.

pwolanin’s picture

Status: Reviewed & tested by the community » Active

No, it won't get committed. It would be too disruptive, and breaking the existing api and installed base is worse than some drush make hiccups.

if anything I'll carry through the suggestion in #1919168: Drush compatibility: Add placeholder node_clone.module and node_clone.info files

pwolanin’s picture

Status: Active » Closed (works as designed)