Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Having the "clone.module" in the "node_clone" project breaks build processes...
rob@Computron /var/www $ drush make drupalbin-profile/drupalbin.make drupalbin
Project information for drupal retrieved. [ok]
Project information for drupalbin_feature retrieved. [ok]
drupal downloaded from [ok]
http://ftp.drupal.org/files/projects/drupal-7.8.tar.gz.
drupalbin_feature downloaded from [ok]
http://ftp.drupal.org/files/projects/drupalbin_feature-7.x-1.x-dev.tar.gz.
Found makefile: drupalbin_feature.make [ok]
Project information for geshifilter retrieved. [ok]
Project information for features retrieved. [ok]
Project information for pathauto retrieved. [ok]
Project information for strongarm retrieved. [ok]
Non-existent project type on project node_clone [error]
Should we move this over to http://drupal.org/project/clone ?
Comment | File | Size | Author |
---|---|---|---|
#9 | consistent_naming-1325940-9.patch | 54.62 KB | lolandese |
Comments
Comment #1
RobLoachSeems to have fixed itself... Should we move the project over sometime though? Maybe when we switch to cloning Entities?
Comment #2
brianV CreditAttribution: brianV commentedNot fixed - latest 7.x dev release still contains the 'clone' module:
Comment #3
pwolanin CreditAttribution: pwolanin commentedComment #4
jorges CreditAttribution: jorges commentedI am using the Features module, have created
my_features_module
wherenode_clone
is a dependency for it.In
my_features_module.info
, this dependency is automatically written by Features asdependencies[] = clone
Now, when I try to install
my_features_module
(with Drush), I receive the following message:Module my_features_module cannot be enabled because it depends on the following modules which could not be found: clone
I guess, this is caused by the inconsistency "node_clone" vs. "clone" described above, am I right?
If yes (also if not), how can I fix the problem?
I am also confused by Comment 3 stating that this "(works as designed)". Is that really the case?
Comment #5
lolandese CreditAttribution: lolandese commentedAttached patch replaces all relevant instances of 'clone_' with 'node_clone_'. It has been done in several search/replace cycles. For what I remember:
' clone_'
'"clone_'
'(clone_'
'%clone_'
'>clone_'
' _clone_'
Furthermore the file names have also been changed accordingly. Some references to 'node_clone.views.inc' needed to be altered manually. Unchanged is the file name 'views_handler_field_node_link_clone.inc'.
I tested locally and it seems to work as before. Just to be scrupulous, uninstall the module first, remove it, git clone the latest version and apply the patch.
Test further on http://simplytest.me/project/node_clone/7.x-1.x?patch[]=https://www.drup... (when it is back up).Thanks.
Comment #6
lolandese CreditAttribution: lolandese commentedBetter.Comment #7
lolandese CreditAttribution: lolandese commentedAnother, hopefully final.
To test:
http://simplytest.me/project/node_clone/7.x-1.x?patch[]=https://www.drup...
Comment #8
lolandese CreditAttribution: lolandese commentedThe previous patch completely neglected Views, Actions and Rules integration. Corrected.
The new test link:
http://simplytest.me/project/node_clone/7.x-1.x?add[0]=ctools&add[1]=vie...
Comment #9
lolandese CreditAttribution: lolandese commentedAgain.
http://simplytest.me/project/node_clone/7.x-1.x?add[0]=ctools&add[1]=vie...
Comment #10
pwolanin CreditAttribution: pwolanin commentedThanks, but changing the module name mid-release would be rather disruptive.
Comment #11
zarabatana CreditAttribution: zarabatana commentedThe following works as expected:
Committing this patch would solve various issues mainly experienced by Drush users and those that try to integrate this module in a distribution (Make file). I do understand some worries about breaking the two provided API functions, but no other contributed modules seem to use them. I don't see other ways the change could be disruptive, rather than fixing things to the way they should be.
Digging in a bit further I was surprised that nowhere in the Coding Standard is specified the project URL should match the project filenames and hook invocations. It is recommended by other sources that by the way also recommend to avoid underscores in project names.
Comment #12
hansfn CreditAttribution: hansfn commentedSure, but the current situation is really bad. I hope this patch gets committed.
Comment #13
pwolanin CreditAttribution: pwolanin commentedNo, it won't get committed. It would be too disruptive, and breaking the existing api and installed base is worse than some drush make hiccups.
if anything I'll carry through the suggestion in #1919168: Drush compatibility: Add placeholder node_clone.module and node_clone.info files
Comment #14
pwolanin CreditAttribution: pwolanin as a volunteer and at Acquia commented