Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This started at #1321774: [meta] Media integration
There seems like there is no way to identify an issuu document url without making an http request, so I guess we should go with the embed code only to start.
This involves mainly to things:
- A read-only stream wrapper for issuu documents.
- Integrate with file_entity for display.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | issuu-media-1323164-9.patch | 38.01 KB | mallezie |
| #8 | issuu-media-1323164-8.patch | 38.19 KB | mallezie |
| #7 | issuu-media-1323164-7.patch | 25.25 KB | mallezie |
| #6 | media_issuu.zip | 20.97 KB | mallezie |
Comments
Comment #1
marvil07 CreditAttribution: marvil07 commentedInitial version on media-integration topic branch.
Comment #2
freblasty CreditAttribution: freblasty commentedHow's the progress on the media integration?
Comment #3
mallezieI started working from the code in the branch. Normally i have a working version by tomorrow.
Comment #4
marvil07 CreditAttribution: marvil07 commentedI do not really remember what was the state of the branch, but I see in the code that it looks ready to review.
It would be great to receive your feedback/patches :-)
Comment #5
mallezieI'm looking to find a way to put all the work in a patch. But my git-skills aren't very good.
worst case i'll upload a zip.
First some feedback:
-I rewrote some of the embed code. So it's possible to embed the url (for example http://issuu.com/chirojeugd-vlaanderen/docs/2011_2012sb_begeleidingsbundel) instead of the embed code.
-It reorders some of the code. (I worked from media_vimeo)
-Removed some of the youtube-code (seems you started there, which was the reason why i started from vimeo, to combine best of both worlds).
-I dont use the issuu-API but get info through embed.ly (to do this through the issuu api is work for today)
-created an image for on the embed from web media page ;-)
First zip now attached, to check, i'll give it a try for a real patch during the day.
Note: issuu has a link in the form of http://issuu.com//docs/
Currently this version still has user hardcoded in for chirojeugd-vlaanderen, so test with documents from following list.
http://issuu.com/chirojeugd-vlaanderen/docs
Greatings
Comment #6
mallezieforgot to add code off cours ;-)
Comment #7
malleziePatching was easier than i thought.
It's a patch against the media-integration branch
Comment #8
mallezieHere is a second patch which does some more.
First testing shows it's completerly working (for the read-only part).
It uses the link of the vimeo page instead of the embed code.
Todo's:
-It uses embed.ly to get the information from the link. Best is to change this to use the issuu_api
-I copied and adjusted the styles code form media_vimeo, but probably this needs to be removed. see http://drupal.org/node/1503158
Comment #9
mallezieAnd a last patch for now.
Changed embed.ly to issuu search api.
Styles probably needs being removed. But i would do that in a follow-up issuu.
Setting needs review for now
Comment #10
aspilicious CreditAttribution: aspilicious commentedIf you got some time, try to optimize your editor. It needs to remove trailing whitespaces ;).
I also advise to look at drupal.org/node/1354 to learn how to write proper and correct documentation for drupal7 code.
ISSUU integration is awesome btw
Comment #11
mallezieYou can find code for this in http://drupal.org/sandbox/mallezie/1538208
See http://drupal.org/node/1321774#comment-6229578
Comment #12
mallezieI'm closing this issue. I commited my sandbox to this code. so basic code is in dev now. Some follow-up issues comming.