To allow other modules to use messages related to tags (annotations) we must add a default method to VersioncontrolTag, ready to be overwritten by backends.

CommentFileSizeAuthor
#1 1322648-api-level-tag-messages.patch520 bytesNiklas Fiekas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Niklas Fiekas’s picture

First try.

Niklas Fiekas’s picture

Status: Active » Needs review
sdboyer’s picture

Status: Needs review » Fixed

yep, just what i was looking for. commushing. now we can sort out what the actual implementation should look like in vc_git land.

Niklas Fiekas’s picture

:)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

marvil07’s picture

Status: Closed (fixed) » Needs work

I am really late here, but I would say we should follow the same pattern we use in operations. That means adding a data member(this sounds like we really need to review code) for the message, and a column to the versioncontrol_labels table, to actually store it, so we can access it from places like views(IMHO we do not want to call repositories for it).

sdboyer’s picture

i don't want a data member. i want separate, backend-specific tables that can be joined in.

the data member is ok on operations b/c it's pretty well established across vcs types that you'll have a commit message. tags are not nearly so standardized, so i'd rather not put something in the generic table which is going to be used different ways, if at all, by different backends.

marvil07’s picture

Status: Needs work » Closed (fixed)

Make sense. Opening #1666622: Support tag messages and re-closing this.

  • Commit daa241a on 6.x-2.x, repository-families, drush-vc-sync-unlock authored by Niklas Fiekas, committed by sdboyer:
    Issue #1322648 by Niklas Fiekas: Added Add a default VersioncontrolTag::...

  • Commit daa241a on 6.x-2.x, repository-families authored by Niklas Fiekas, committed by sdboyer:
    Issue #1322648 by Niklas Fiekas: Added Add a default VersioncontrolTag::...