On line 32, unknown function "db_result". Once I fixed it a new bug appeared in db_query_range. Here is my fix of the bug.

CommentFileSizeAuthor
#5 constraint_delay.inc-1315696-5.patch860 byteserikwebb
#4 constraint_delay.inc-1315696-2.patch1.07 KBkmasood
constraint_delay.patch1.35 KBangel.h

Comments

erikwebb’s picture

erikwebb commented
Title: Bug in the Drupal 7 version in constraint_delay.inc » constraint_delay.inc still uses D6 database functions
Status: Active » Needs work

Could you submit this as a proper patch file?

kmasood’s picture

kmasood commented

Doesn't look like this made it ... will it be part of beta3?

KM

erikwebb’s picture

erikwebb commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev

If this can be converted to a proper patch, I'd be glad to review it.

kmasood’s picture

kmasood commented
StatusFileSize
new constraint_delay.inc-1315696-2.patch1.07 KB

Thanks @erikwebb. Patch attached based on what @angel.h provided.

KM

BTW, this is the first patch for me, so lemme know if I messed up, I'll gladly resubmit.

erikwebb’s picture

erikwebb commented
Status: Needs work » Needs review
StatusFileSize
new constraint_delay.inc-1315696-5.patch860 bytes

I reformatted your patch a little bit. Also, when submitting a patch, make sure to mark the issue "needs review" to get the attention of reviewers.

kmasood’s picture

kmasood commented

Thanks @erikwebb. Lemme know if you need help testing this out.

erikwebb’s picture

erikwebb commented

Yes, please. I currently don't have a good setup for testing this out.

matt v.’s picture

matt v. commented
Status: Needs review » Reviewed & tested by the community

I had trouble getting the patch to apply for some reason, but it was easy enough to apply by hand. The change fixed the "unknown function" error for me.

erikwebb’s picture

erikwebb commented
Status: Reviewed & tested by the community » Fixed

Matt V. - What problems did you have? Make sure to use "git apply" instead of the patch command (http://drupal.org/node/707484).

Fixed and committed.

http://drupalcode.org/project/password_policy.git/commit/932de99

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.