Administer content permission necessary for having the states visible in the node edit form [#1312484]

 if ($states = workbench_moderation_states_next($moderation_state, $user, $form['type']['#value'])) {

adds the possible next states to the node edit form in

    $form['options']['workbench_moderation_state_new'] = array(

but that tab is only visible when you have the 'Administer content' permission set.

So when you don't have that permission but you do have 'bypass moderation' the different states are added to the form but are not visible. So that dropdown should be added to the revision_information fieldset when the options tab is not there.

Comment	File	Size	Author
#8	wbm-form-1312484-8.patch	1.45 KB	stevector
#5	workbench_moderation.patch	1.44 KB	jax
#4	1312484_make_moderation_state_field_visible_4.patch	766 bytes	juampynr

Comments

Comment #1

stevector

he/him

commented 17 October 2011 at 20:56

Status:

Active

» Postponed (maintainer needs more info)

Are you using the dev branch?

I thought this was fixed in #1089930: Moving the revision log message makes it inaccessible to normal editors

Comment #2

jax commented 18 October 2011 at 14:45

I was using the dev branch. I'll doublecheck.

Comment #3

stevector

he/him

commented 25 October 2011 at 18:56

Status:

Postponed (maintainer needs more info)

» Active

I think I was just able to reproduce this.

Comment #4

juampynr commented 2 November 2011 at 12:34

Status:

Active

» Needs review

Status	File	Size
new	1312484_make_moderation_state_field_visible_4.patch	766 bytes

No, #1089930: Moving the revision log message makes it inaccessible to normal editors does not fix it.

Here is a patch that allows users who can set state transitions to view the "Moderation state" and "Moderation notes" fields when editing or creating content.

Please consider git authorship.

Comment #5

jax commented 14 November 2011 at 23:33

Status:

Needs review

» Needs work

Status	File	Size
new	workbench_moderation.patch	1.44 KB

I would rather do it like the attached patch. By default add it to the place where the log message is. And if the person has access to the publishing options move everything.

With this solution people that can choose the next state have the option to set it even if they do not have administer content.