Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The module lacks the ability to have the strings translated, hence its usage is somewhat limited on a multilingual site.
Comment | File | Size | Author |
---|---|---|---|
#10 | 1312030-10-make-strings-translatable.patch | 1.51 KB | mike.davis |
#8 | 1312030-8-make-strings-translatable.patch | 1.01 KB | muschpusch |
#4 | autoassignrole-n1312030-4.patch | 3.3 KB | DamienMcKenna |
#3 | patch-strings_and_minor_logic.txt | 3.32 KB | SKAUGHT |
#3 | patch-uninstall_variables.txt | 605 bytes | SKAUGHT |
Comments
Comment #1
dkliewer CreditAttribution: dkliewer commentedI've hacked a quick solution which makes the fields translatable (variables module required).
Add the following hook at the end of autoassignrole.module:
This enables the three fields for translation via Configuration > Multilingual Settings > Variables
They can then be translated by using Configuration > Variables > Modules > Auto Assign Role
Comment #2
Hess CreditAttribution: Hess commentedThanks!
Comment #3
SKAUGHThere a fix for some of the strings...they just shouldn't be in the variable table.
and a little uninstall of variables too.
EDIT:
sorry i now see the little logic fix won't really help. i don't' take the time to work it out right now, sorry--gotta focus on my own task at hand.
Comment #4
DamienMcKennaThe strings_and_minor_logic file in patches in #3 changes some logic that didn't need to be changed, and we already have a working uninstall script per another issue.
This patch reformats the field descriptions from autoassignrole.admin.inc to make translation easier.
Comment #5
DamienMcKennaCommitted.
Comment #6
DamienMcKennaClosing this to clean up the issue queue as 7.x-1.0-beta1 was released.
Comment #7
muschpusch CreditAttribution: muschpusch commentedSorry for reopening this but the reformatting of the descriptions isn't the issue here. We want the actual values to be translated which #1 fixes. Please have a look at the variable project page
Comment #8
muschpusch CreditAttribution: muschpusch commentedhere #1 as a patch but in a seperate file since variable seems to support some lazy loading. Please review!
Comment #10
mike.davis CreditAttribution: mike.davis at Deeson commentedI have updated this patch with the changes to the description field to be a text_format and updated the variables to be in a module group.
Comment #12
mike.davis CreditAttribution: mike.davis at Deeson commentedThis has been committed to 7.x-1.x. Need to apply to 7.x-2.x now
Comment #14
mike.davis CreditAttribution: mike.davis at Deeson commentedAll committed now