Lines 560 and 561 of mimemail 6.x-1.0-beta2 have issues with E_NOTICE in that they assume that the $url will have a hash (pound) symbol and a question mark respectively, so the list() call fails if they don't.

I've attached a patch which uses a more robust method here, and does not trigger E_NOTICE errors.

CommentFileSizeAuthor
#3 mimemail_1308628_02.patch539 bytessgabe
mimemail_notices.patch1.13 KBchriscohen

Comments

ibes’s picture

ibes commented

this is also in mimemail 7.x

sgabe’s picture

sgabe commented
Status: Active » Needs review

This needs review.

sgabe’s picture

sgabe commented
Title: Notice: Undefined offset: 1 in _mimemail_url() » List function throws notice
Version: 6.x-1.0-beta2 » 6.x-1.x-dev
Status: Needs review » Fixed
StatusFileSize
new mimemail_1308628_02.patch539 bytes

I think here it's enough and safe to use the @-operator for the list() call. The value of the empty/missing variables will be NULL, we just need to get rid of the notice.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.