login_destination_admin_settings_validate() doesn't conform to E_NOTICE in PHP 5.3. Rather than using $x .= $y inside a loop on an (initially) undefined variable, the code should first initialise the variable.

I have attached a patch. It seems that the code doesn't conform to Drupal coding standards (http://drupal.org/coding-standards#indenting) and my IDE has stripped out a lot of trailing whitespace, so I'm afraid the patch looks a lot more complicated than it is.

You could just choose to reject the patch and add...
$warn_vars = '';
...immediately inside the login_destination_admin_settings_validate() function, since that's all that's changed.

CommentFileSizeAuthor
login_destination_warn_vars.patch6.18 KBchriscohen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rsvelko’s picture

Issue summary: View changes
Status: Active » Fixed

just commited
[6.x-2.x 59cf3dd] remove not needed hook_validate, was used for displaying debug message before

I removed the hook_validate altogether and this solves the E_NOTICE too.

rsvelko’s picture

Assigned: Unassigned » rsvelko

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.