(Like all of the patches which I'm currently posting, this is based on #1164578: Port and extend tests so that one needs to be commited first as this one mit not apply cleanly otherwise)
There are currently a few bogus @todo strings in permission and token descriptions. That's bad because they are added to the i18n database and are supposed to be translated.
That's kinda pointless, they should either be removed or a proper description should be added if necessary.
The attached patch removes them and also a few @todo's in comments which are obviously resolved.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | todo2.patch | 4.45 KB | berdir |
| todo.patch | 4.34 KB | berdir |
Comments
Comment #1
simon georges commentedThanks for the effort!
Maybe some of them (the one on tokens, for example) should rather be converted to comments in code (having them in translated strings doesn't make any sense), what do you think ?
Comment #2
berdirProbably, the tokens needs to be improved anyway.
For example, it would probably make sense to add a 'node' token to the newsletter issue which allows to access all node tokens. I also have a patch to replace the custom token list with the token_tree from token.module, which I'll post when I find the time (I was working on these issues without having internet access and am now going trough them when I have time to publish patches).
Comment #3
simon georges commentedOk, changing to needs work to rework the todo into comments.
Comment #4
berdirOk, added the todo.
Comment #5
simon georges commentedThanks, committed.