Provide add-redirect command for drush

works as advertised, very straightforward patch, and very helpful; thanks.

Very useful. Patch still working. Should be committed.

i was just about to write this patch myself to import ~100 aliases. thanks, acrollet!

one tiny suggestion: make the default option 0, which will use whatever default redirection option is configured at admin/config/search/redirect/settings. trivial new patch attached.

#4 works as advertised, still
RTBC++

This is the oldest RTBC issue in the queue.
Can we get it in, or at least reviewed by a maintainer?

In general I agree this is RTBC. I tested it out a bit and it worked to create redirects.

If I put on my super-picky-hat, here are things that could be improved:

1. The comment about redirect loops is not a sentence and not capitalized.
2. Several lines are longer than 80 characters
3. The error about redirect hash being in use doesn't have a comment (either both error conditions should have comments or neither should).
4. The $dest variable is an abbreviation that is not a word and it is not consistent with the module's code - throughout the module the "dest" is generally called a redirect

Attached patch addresses the nitpicking in #6. I actually kept the $dest variable (though renamed it to $destination) because otherwise there is a string variable $redirect and a newly created $redirect object clobbers it. I guess this is an example of procedural and OO code not mixing well.

Added docblock information for the function and used the optional $defaults second parameter to redirect_object_prepare instead of just overwriting the resulting object properties.

Patch in #7 seems to break the "code" argument. Using the example command drush add-redirect 'node/1' 'http://google.com' 302
Adds the redirect, but redirect code is always the Default (301) regardless of what code is entered in the drush command for me.

Patch in #4 works as expected with the example command.

Perhaps it should be using status_code as the arry key instead of redirect_object_prepare?

Yep, that's how it's used in redirect.admin.inc

#10 works as expected for me!

1. +++ b/redirect.drush.inc
   @@ -19,11 +20,61 @@ function redirect_drush_command() {
   +    drush_set_error('redirect', t('You are attempting to redirect the page to itself. This would result in an infinite loop.'));
   

   Should use "return drush_set_error(...);" here.

2. +++ b/redirect.drush.inc
   @@ -19,11 +20,61 @@ function redirect_drush_command() {
   +      drush_set_error('redirect', t('The source path %source is already being redirected to %redirect.', array('%source' => redirect_url($redirect->source, $redirect->source_options), '%redirect' => redirect_url($existing->redirect))));
   

   Same here.

3. +++ b/redirect.drush.inc
   @@ -19,11 +20,61 @@ function redirect_drush_command() {
   +  if (!drush_get_error()) {
   

   Then there's no need for this. Simpilfied!

An updated patch with the suggested improvements.

looks good here, acrosman

Hi,

I used the patch #13 last week for ~70 redirects and worked like a charm. Do you guys have any expectation date to commit it?

One thing that I think that could be very useful, add a -f flag, so it can overwrite a existent redirect with a new one.

Thanks all.

Regards,

looks promising, looking for a language parameter

Ok, here's a newer patch that supports the language parameter instead of just default "language_undefined"

language is needed especially for multilingual or bilingual sites when redirecting internal paths.

I think a language code makes a lot of sense, but probably as an optional parameter at the end of the command. Seems likely that it's the least common use case compared to the other parameters.

I agree that the language parameter should be optional, and that the simplest way to do that would be to put it last.

Adding a -f flag would be nice but shouldn't block this patch.

Updated patch with optional language and status code.

Here is the previous patch with default language value fixed.

Nice work @jfhovinne ,

RTBC patch 23

RTBC

Nice work. +1