I just noticed that my panels suddenly did not have rounded corners when they previously had them on. I cleared the cache, checked and re-checked my custom css files and custom code, but finally tracked it down to the "Aggregate and compress CSS files" setting in the Performance page.
I had enabled that option before to see if it improved performance. Turning it off and clearing the cache un-broke the rounded corners.

Hoping that this gets a fix.

CommentFileSizeAuthor
#12 panels-rounded_corners_breaks_when_aggregating_css-1300284-7.patch515 bytesXerraX

Comments

sheena_d’s picture

sheena_d commented
Assigned: Unassigned » sheena_d
Status: Active » Postponed (maintainer needs more info)

A lot of times when CSS compression causes styling to break, it is because there is invalid CSS somewhere in the cascade, which causes part of the CSS to get thrown out or interpreted incorrectly.

I would sugest running your site through a CSS validator (jigsaw.w3.org/css-validator/) and checking out any warnings it throws, especially parse errors, and see if fixing those errors allows the rounded corners to work correctly while CSS compression is turned on.

If you don't find any CSS validation errors as the root cause, I will investigate further - in which case a link to your site would be very helpful.

Cheers,
Sheena

Anandkumar’s picture

Anandkumar commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

You're right; there are a lot of css validation errors in my site! I did not even think to check for validation errors because I did not have any custom css in my site; only those from drupal contrib modules.
Since there are over ~180 errors (not including warnings!) according to jigsaw, and since the site looks and works good across browsers anyway, I guess won't be turning-on the "aggregate" settings for the CSS for my site.
Thanks anyway!

esculcar’s picture

esculcar commented

Could this have something to do? http://drupal.org/node/1136788
Thanks

sheena_d’s picture

sheena_d commented

@edum1978 this sort of thing is usually caused by incorrect syntax - missing semi-colons or brackets - which create completely incomplete, rather than just incorrect, CSS rules. The W3C validation errors listed in that Drupal core issue are valid CSS rules, they are just not defined by the W3C, thus they trigger errors with W3C validation.

dimon00’s picture

dimon00 commented

I'm having the same problem.

I tried to comment out the css errors showed in
http://jigsaw.w3.org/css-validator/
but the problem persists.

Here a link to my website:
www.centrovolantini.it

When I enable the option I cannot see any
.rounded-corner
.t-edge, .b-edge, .l-edge, .r-edge, .wrap-corner
definition.

The dynamic CSS generated in rounded_corners.inc doesn't seem to be imported.

XerraX’s picture

XerraX commented
Status: Closed (works as designed) » Active

Got the same problem on my D7 Dev environment. Fixed all CSS validation errors but problem persists.

XerraX’s picture

XerraX commented

Possible workaround (at least for me)

in panels\plugins\styles\corners\rounded_corners.inc

find:

drupal_add_css($filename, 'module', 'all', FALSE);

and replace it with:

drupal_add_css($filename, array('group' => CSS_THEME, 'preprocess' => TRUE));

merlinofchaos’s picture

merlinofchaos commented
Priority: Minor » Normal

Oh my. That would look like another D6 -> D7 upgrade miss.

Though 'group' => CSS_THEME I think means it's part of the theme which is wrong. I believe we should leave group alone or use CSS_MODULE?

XerraX’s picture

XerraX commented
Priority: Normal » Minor

CSS_DEFAULT is the module layer

merlinofchaos’s picture

merlinofchaos commented
Priority: Minor » Normal

I believe this is more than minor because of the breakage it comes with. :)

CSS_DEFAULT is the default so we shouldn't even need to specify it.

XerraX’s picture

XerraX commented

accidentally changed Priority

XerraX’s picture

XerraX commented
Assigned: sheena_d » XerraX
Status: Active » Needs review
StatusFileSize
new panels-rounded_corners_breaks_when_aggregating_css-1300284-7.patch515 bytes

my first git generated patch ^^ hope its correct

BuFr’s picture

BuFr commented

#12 worked perfect

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Looks reasonable. Committed.

Anandkumar’s picture

Anandkumar commented

Thanks to all who worked out a fix for this issue. I can now tentatively turn back on the aggregation performance settings :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 0c7bdae on 7.x-3.x, 7.x-3.x-i18n, 8.x-3.x by merlinofchaos: 
    Issue #1300284 by XerraX: Fix rounded corners CSS during aggregation.