Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Since the module stores the number of times a piece of content has been emailed. It would be nice to expose this information to views through a sub-module. This would allow creating arbitrary lists of content and giving the user the ability to sort by most or least emailed.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | print-1299150-6.patch | 1.84 KB | lliss |
| #3 | provide_views_integration_for_most_emailed-1299150-3.patch | 3.42 KB | lliss |
| #1 | provide_views_integration_for_most_emailed-1299150.patch | 2.2 KB | lliss |
Comments
Comment #1
lliss CreditAttribution: lliss commentedThis patch provides the functionality for nodes.
Comment #2
lliss CreditAttribution: lliss commentedUPDATE: Okay that last patch is broken due to passing in bad table_alias with $this->table_alias. Rolling another shortly.
Comment #3
lliss CreditAttribution: lliss commentedThis one fixes the issue with the broken table alias. Still having some trouble with the aliases though so this one is basically hard coded. The result is that this might not work if there are more complex views being built. It seems to fail if there are multiple instances of the sort and it might fail if there are relationships.
Comment #4
jcnventura CreditAttribution: jcnventura commentedThanks for the patch. Comitted it to git.
Comment #6
lliss CreditAttribution: lliss commentedThe way you rewrote the code prior to commuting the fix left the views handler broken. The include file for the views handler needs to be in the .info file. Also the handler should not be named starting with views but should be prefixed with the module name, in this case print_mail. Finally we don't need the other include files called specifically in the .info file. A patch is attached. Also, can me move this into the 2.x branch as well.
Comment #7
jcnventura CreditAttribution: jcnventura commentedAh, don't worry about that... I'm not integrating any new patches until I finish 2.x :)
Comment #8
jcnventura CreditAttribution: jcnventura commentedThanks for the heads-up.. In the meantime, I learned how to use Views properly, so now the module has proper support for all fields.
I've just committed this support to all the devs, as the code was completely isolated from the specificities of the different branches.