Since the module stores the number of times a piece of content has been emailed. It would be nice to expose this information to views through a sub-module. This would allow creating arbitrary lists of content and giving the user the ability to sort by most or least emailed.

CommentFileSizeAuthor
#6 print-1299150-6.patch1.84 KBlliss
#3 provide_views_integration_for_most_emailed-1299150-3.patch3.42 KBlliss
#1 provide_views_integration_for_most_emailed-1299150.patch2.2 KBlliss

Comments

lliss’s picture

lliss commented
Status: Active » Needs review
StatusFileSize
new provide_views_integration_for_most_emailed-1299150.patch2.2 KB

This patch provides the functionality for nodes.

lliss’s picture

lliss commented

UPDATE: Okay that last patch is broken due to passing in bad table_alias with $this->table_alias. Rolling another shortly.

lliss’s picture

lliss commented
StatusFileSize
new provide_views_integration_for_most_emailed-1299150-3.patch3.42 KB

This one fixes the issue with the broken table alias. Still having some trouble with the aliases though so this one is basically hard coded. The result is that this might not work if there are more complex views being built. It seems to fail if there are multiple instances of the sort and it might fail if there are relationships.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Fixed

Thanks for the patch. Comitted it to git.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lliss’s picture

lliss commented
Status: Closed (fixed) » Needs review
StatusFileSize
new print-1299150-6.patch1.84 KB

The way you rewrote the code prior to commuting the fix left the views handler broken. The include file for the views handler needs to be in the .info file. Also the handler should not be named starting with views but should be prefixed with the module name, in this case print_mail. Finally we don't need the other include files called specifically in the .info file. A patch is attached. Also, can me move this into the 2.x branch as well.

jcnventura’s picture

jcnventura
Primary language English
commented

Ah, don't worry about that... I'm not integrating any new patches until I finish 2.x :)

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Fixed

Thanks for the heads-up.. In the meantime, I learned how to use Views properly, so now the module has proper support for all fields.

I've just committed this support to all the devs, as the code was completely isolated from the specificities of the different branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.