When Feedback Time is set to After Each question - on the last question, no feedback is shown, but Quiz displays the quiz score page only.

CommentFileSizeAuthor
#9 feedback_last_question_1298044_d6.patch1.43 KBrballou
#7 feedback_last_question-5682986-1298044.patch1.63 KBipwa
#6 feedback_last_question-5682986-1298044.patch1.63 KBipwa
#2 feedback_last_question-1298044-2.patch1.56 KBguillaumev

Comments

guillaumev’s picture

guillaumev commented

Note that this bug also appears in the 7.x version...

guillaumev’s picture

guillaumev commented
Status: Active » Needs review
StatusFileSize
new feedback_last_question-1298044-2.patch1.56 KB

Here is a patch fixing the issue in version 7.x-4.x. It hasn't been tested very well and I haven't seen the code of 6.x-4.2 but I guess/hope it will be easy to adapt...

falcon’s picture

falcon commented
Version: 6.x-4.2 » 7.x-5.x-dev

The feedback system will be reworked for quiz 5 and we will fix this problem then.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Version: 7.x-5.x-dev » 7.x-4.x-dev
Status: Needs review » Fixed

Just added a workaround code to quiz_take_quiz() to fix this. Seems to work okay for me.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ipwa’s picture

ipwa commented
StatusFileSize
new feedback_last_question-5682986-1298044.patch1.63 KB

@falcon its great that the feedback system will be reworked.

However this is a bug and it should be fixed on 7.x-4.x since its the current release and a lot of people are using the module with this bug. If a fix gets committed you will have less support issue requests related to feedback :)

Attempting to re-roll patch since it didn't apply cleanly.

ipwa’s picture

ipwa commented
StatusFileSize
new feedback_last_question-5682986-1298044.patch1.63 KB

@falcon its great that the feedback system will be reworked.

However this is a bug and it should be fixed on 7.x-4.x since its the current release and a lot of people are using the module with this bug. If a fix gets committed you will have less support issue requests related to feedback :)

Attempting to re-roll patch since it didn't apply cleanly.

ipwa’s picture

ipwa commented
Status: Closed (fixed) » Needs review

I can confirm this works well.

The patch applies cleanly in dev and it applies in the alpha12 release although you get a couple of offset warnings.

rballou’s picture

rballou commented
StatusFileSize
new feedback_last_question_1298044_d6.patch1.43 KB

This used to be related to a 6.x release and the patch above is for 7.x. I have created the following patch for 6.x which also seems to work:

mcpuddin’s picture

mcpuddin commented
Status: Needs review » Closed (fixed)

This is in 7.x-4.x-dev already (comment #4). I'm closing out this issue. If you a d6 patch, I'd say open it up in a different issue.