It would be nice if the hash plugin provided an option to create the hash over only the sources being used in the importer.

I have a feed that has many often-changing sources, but I'm only interested in importing and tracking changes to only a select few.

Files: 
CommentFileSizeAuthor
#6 feeds_tamper-hash_only_chosen_fields-1297650-6.patch1.98 KBqueenvictoria
FAILED: [[SimpleTest]]: [MySQL] 811 pass(es), 10 fail(s), and 1 exception(s).
[ View ]

Comments

twistor’s picture

Assigned:Unassigned» twistor

I like it!

twistor’s picture

I'm thinking that we should have two separate plugins for backwards compatibility. I can mark the old one deprecated in the UI. But leave it for a while. hmm...

jeffschuler’s picture

Thanks for your support of this.
Why not provide both options? There are potential use cases for both.

twistor’s picture

I don't really want two plugins that do almost the same thing. At the same time, I don't want to have a check for the old configuration on every run either. Although I was making it more complicated than it had to be. I'll just add an upgrade routine the moves existing configurations over to the new one.

jeffschuler’s picture

Sounds good. This way of doing it is more sensible anyway, and can accommodate the other use case.

queenvictoria’s picture

StatusFileSize
new1.98 KB
FAILED: [[SimpleTest]]: [MySQL] 811 pass(es), 10 fail(s), and 1 exception(s).
[ View ]

I've created a patch to add the import fields as checkboxes and default to `all fields` if no fields are checked. It needs a bit of testing but its a start.
The reason I've implemented this differently is I want to import all the fields but only test uniqueness on some of them (as some source fields change when they shouldn't).

queenvictoria’s picture

Status:Active» Needs review

Status:Needs review» Needs work

The last submitted patch, feeds_tamper-hash_only_chosen_fields-1297650-6.patch, failed testing.