made #node_edit_form obsolete.
There's already a @todo in node_form() to remove #node_edit_form entirely for D8.
The replacement condition is to check for $form_state['build_info']['base_form_id'] == 'node_form'
instead.
Comment | File | Size | Author |
---|---|---|---|
#25 | 1297410-25.patch | 1.78 KB | bfroehle |
#20 | remove_pound_node_edit_form-1297410.patch | 1.4 KB | bfroehle |
#17 | drop-remnants-of-node-edit-form-1297410-16.patch | 1.2 KB | bhosmer |
#15 | drop-remnants-of-node-edit-form-1297410-8.patch | 1.66 KB | bhosmer |
#13 | drop-remnants-of-node-edit-form-1297410-8.patch | 1.7 KB | bhosmer |
Comments
Comment #1
bhosmer CreditAttribution: bhosmer commentedWell, here goes my first try at contributing a patch to core.
Comment #2
bhosmer CreditAttribution: bhosmer commentedComment #3
bhosmer CreditAttribution: bhosmer commentedComment #5
bhosmer CreditAttribution: bhosmer commentedComment #6
sunThe removals are OK, but should actually include the comment.
And the new condition actually needs to be used wherever #node_edit_form is currently used throughout core. (most likely, in tests only)
-13 days to next Drupal core point release.
Comment #7
bhosmer CreditAttribution: bhosmer commentedFrom looking at the simpletest, I see it was also used in the forum. module too.
What comment are you referring to that still needs to be included?
Comment #8
sunThe chunk of lines you touched in node_form() can be removed entirely; i.e., including the comment, and without replacement.
Comment #9
bhosmer CreditAttribution: bhosmer commentedCool. Thanks.
Now, what about forum.module:
I assume this entire function can be removed or not?
Comment #10
bhosmer CreditAttribution: bhosmer commentedComment #12
bhosmer CreditAttribution: bhosmer commentedComment #13
bhosmer CreditAttribution: bhosmer commentedComment #15
bhosmer CreditAttribution: bhosmer commentedComment #17
bhosmer CreditAttribution: bhosmer commentedComment #19
bhosmer CreditAttribution: bhosmer commentedWhat should I do with the forum problems? Any advice would be appreciated.
Comment #20
bfroehle CreditAttribution: bfroehle commentedI split the relevant section of code out to forum_form_node_form_alter() (i.e., an implementation of hook_form_BASE_FORM_ID_alter).
Comment #21
sunThanks all!
Comment #22
chx CreditAttribution: chx commentedSo agreed. A followup patch should rename the node form to node_form_$node_type. But for now, this is great.
Comment #23
catch#20: remove_pound_node_edit_form-1297410.patch queued for re-testing.
Comment #25
bfroehle CreditAttribution: bfroehle commentedRerolled after /core.
Comment #26
Dries CreditAttribution: Dries commentedNice little clean-up. Committed to 8.x. Thanks!
Comment #27
sunThis needs an API change notice.
Comment #28
bfroehle CreditAttribution: bfroehle commentedChange notice created: $form['#node_edit_form'] removed
Comment #29
xjmI updated the change notice with corrections from the comments.