Imagefield_zip doesn't work with cck-2.9 (which is the latest supported one for D6 at the time of writing): imagefield_zip.ahah.inc relies on the existence of content_set_nested_elements() function which only exists in the cck-3.x branch. After upgrading cck to 3.0-beta3 (the latest D6 release of it at the time of writing), imagefield_zip starts working well.

Please point sitebuilders' focus to the fact that cck-3.x is needed for imagefield_zip to make it work at all.

PS. Finally we got imagefield_zip-6.x-1.0, which is a great job, and works like it should. Thanks!

CommentFileSizeAuthor
#7 imagefield_zip-1296522-7.patch625 bytesmikeytown2
#3 imagefield_zip-1296522-3.patch1.45 KBmikeytown2

Comments

narongwit12’s picture

narongwit12 commented

Thank you so much. The problem is perfectly solved.

mikeytown2’s picture

mikeytown2 commented

I'll be working on bringing back CCK2 support; having that as a requirement isn't ideal.

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new imagefield_zip-1296522-3.patch1.45 KB

Gonna need some testing here, this patch has been committed but there might be other functions missing or errors when using cck2.

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Postponed (maintainer needs more info)

marking as postponed until I hear back a yea or nea.

mikeytown2’s picture

mikeytown2 commented
Version: 6.x-1.0 » 6.x-1.x-dev
gsbc’s picture

gsbc commented
Status: Postponed (maintainer needs more info) » Needs work

There are also a couple calls to content_get_nested_elements on lines 185 and 387 of imagefield_zip.ahah.inc which also require CCK 3.x+

I'll try giving this a shot and post a patch later.

mikeytown2’s picture

mikeytown2 commented
Status: Needs work » Postponed (maintainer needs more info)
StatusFileSize
new imagefield_zip-1296522-7.patch625 bytes

The call on 387 can be ignored because that code path can only happen in CCK3.

content_get_nested_elements is a self contained function so we could call an alternative version of the code; but something I noticed is imagefield_zip_array_find_element_by_key() looks very close to content_get_nested_elements(). I've tested this and it appears to work; I've replaced content_get_nested_elements with imagefield_zip_array_find_element_by_key on line 185.

Patch below has been committed. Let me know if you find any other issues with CCK2.

gsbc’s picture

gsbc commented

I can confirm it works with the patch at #7 (with CCK 2.9)

mikeytown2’s picture

mikeytown2 commented
Status: Postponed (maintainer needs more info) » Fixed

Marking this as fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.