Hi

In some use cases (as mine now) you want to validate that the mail entered in login form is ok and you want to force login only by email, this can be accomplished just with a custom validate handler that validates the email but email_registration doesn't keep this data.
I'm attaching a really little patch for keeping the email address in the validation phase.

Files: 
CommentFileSizeAuthor
#6 1291908-keep_email_for_validate-6.patch726 bytesgreggles
PASSED: [[SimpleTest]]: [MySQL] 17 pass(es).
[ View ]
#2 1291908-keep_email_for_validate-2.patch756 bytespcambra
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1291908-keep_email_for_validate-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#1 1291908-keep_email_for_validate-1.patch720 bytespcambra
PASSED: [[SimpleTest]]: [MySQL] 17 pass(es).
[ View ]

Comments

pcambra’s picture

Status:Active» Needs review
StatusFileSize
new720 bytes
PASSED: [[SimpleTest]]: [MySQL] 17 pass(es).
[ View ]
pcambra’s picture

StatusFileSize
new756 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1291908-keep_email_for_validate-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

It should be done before the user check.

andypost’s picture

Great but this should be configurable or not? this adds an option #583152-13: email confirmation option

greggles’s picture

Title:Keep the email login entered by the user» Keep the email login entered by the user so it can be validated

Makes sense to me.

Status:Needs review» Needs work

The last submitted patch, 1291908-keep_email_for_validate-2.patch, failed testing.

greggles’s picture

Status:Needs work» Needs review
StatusFileSize
new726 bytes
PASSED: [[SimpleTest]]: [MySQL] 17 pass(es).
[ View ]

reroll.

greggles’s picture

Version:7.x-1.x-dev» 6.x-1.x-dev
Status:Needs review» Patch (to be ported)
greggles’s picture

Status:Patch (to be ported)» Fixed

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.