Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Sep 2011 at 19:59 UTC
Updated:
4 Jan 2014 at 01:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jhodgdonThanks -- looks like that sentence should just be removed. Good project for a novice contributor!
Comment #2
arithmetric commentedAttached is a patch that removes this obsoleted comment.
Comment #3
jhodgdonThanks! Let's get this into 8.x and 7.x.
Comment #4
catchNo brainer for 8.x. Committed and pushed.
For 7.x we technically support 5.2.4+ so it's feasible that someone is running that version somewhere. Marking CNR again for that.
Comment #5
jhodgdonHm. Actually, I wasn't clear from reading the php.net bug report exactly which versions it was in, and which ones it had been fixed in. The page didn't give me that information that I could tell.
A larger question: do we want to have that line in there, even if it's relevant? we don't normally go around documenting PHP bugs, do we?
Comment #6
jhodgdonComment #7
mike stewart commentedI agree with @jhodgdon that this bug message is misplaced and should be removed from core.
No port necessary because the patch was made before D8 directory restructuring, it still applies cleany to Drupal 7.x (235d8c commit / 7.12 is most recent tag).
* Patch applies clean.
* Verified it removes the two lines in question in file:
includes/database/database.incComment #8
jhodgdonThis has been marked RTBC for 8 days and no one has objected to the idea of removing this, so I went ahead and committed it to 7.x.