API page: http://api.drupal.org/api/drupal/includes--database--database.inc/functi...

The note about not setting the PDO::ATTR_DEFAULT_FETCH_MODE attribute only applies if running PHP 5.2.4 or early release candidates of 5.2.5 (which no one should be running). The bug did not exist in earlier versions and was fixed in later versions.

Comments

jhodgdon’s picture

Title: Documentation problem with Database::getConnection » Database::getConnection mentions short-lived fixed bug and shouldn't
Version: 7.x-dev » 8.x-dev
Issue tags: +Novice, +Needs backport to D7

Thanks -- looks like that sentence should just be removed. Good project for a novice contributor!

arithmetric’s picture

Status: Active » Needs review
StatusFileSize
new545 bytes

Attached is a patch that removes this obsoleted comment.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Thanks! Let's get this into 8.x and 7.x.

catch’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Needs review

No brainer for 8.x. Committed and pushed.

For 7.x we technically support 5.2.4+ so it's feasible that someone is running that version somewhere. Marking CNR again for that.

jhodgdon’s picture

Hm. Actually, I wasn't clear from reading the php.net bug report exactly which versions it was in, and which ones it had been fixed in. The page didn't give me that information that I could tell.

A larger question: do we want to have that line in there, even if it's relevant? we don't normally go around documenting PHP bugs, do we?

jhodgdon’s picture

Status: Needs review » Patch (to be ported)
mike stewart’s picture

Status: Patch (to be ported) » Reviewed & tested by the community

I agree with @jhodgdon that this bug message is misplaced and should be removed from core.

No port necessary because the patch was made before D8 directory restructuring, it still applies cleany to Drupal 7.x (235d8c commit / 7.12 is most recent tag).

* Patch applies clean.
* Verified it removes the two lines in question in file: includes/database/database.inc

jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

This has been marked RTBC for 8 days and no one has objected to the idea of removing this, so I went ahead and committed it to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.