Use invisible instead of non-existent field labels for accessibility

Thanks stella, I haven't had time to look at this patch so it got buried in the Webform queue. The D6 patch looks pretty good.

In the D7 patch, this doesn't seem to make any sense, why would you run check_plain() on a property that doesn't exist? Even if the logic is inverted, what's this providing?

+  if (empty($component['extra']['attributes']['title'])) {
+    $component['extra']['attributes']['title'] = check_plain($component['name']);
+  }

It'd probably be better to move this bit of code up above the setting of the $element variable.

+  // If #title_display is none, set it to invisible instead - none only used if
+  // we have no title at all to use.
+  if ($element['#title_display'] == 'none') {
+    $variables['element']['#title_display'] = 'invisible';
+    $element['#title_display'] = 'invisible';
+  }

Oh, for some reason I thought the code was this, just setting the property to itself:

+ if (empty($component['extra']['attributes']['title'])) {
+ $component['extra']['attributes']['title'] = check_plain($component['extra']['attributes']['title']);
+ }

I'm just being crazy apparently. I'll take another look at this.

The title attribute is certainly a good way to do this. In D7 you can also just add '#title_display' => 'invisible', when defining the form element and it will be hidden to the display, but also accessible to screen readers. It doesn't use the title attribute, but it still meets WCAG 2.0 AA guidelines.

Reroll.

That works well. I spun up an instance with SimplyTest.me and grabbed this screenshot:

Thanks for pushing this ahead Liam.

Thanks Liam and stella, this is committed to the 7.x-4.x branch.

Thanks!

This patch introduced a Notice error when creating components: #2020705: Notice: Undefined index: name in webform_component_defaults().

Re-rolling for people still using 7.x-3.x (the patches above no longer apply).

Are backports to 7.x-3.x still being considered?

Sure @andrewmacpherson, I think this would be valid for backporting. Thanks for the reroll. I'm not updating the 7.x-3.x as frequently as the 7.x-4.x branch, but I'll make sure this gets in next time I'm reviewing patches.

Did this get in 7.x-4.0-beta1?

Yes.

The 4.x patch was causing PHP notices apparently. This patch was revised in #2020705: Notice: Undefined index: name in webform_component_defaults() to work in a more graceful manner. The 3.x backport no longer applies and should use the same approach used in that fix. Really I'd prefer to just say, "use 4.x", but if this patch is rerolled for 3.x it'll get in eventually.

At this rate, it looks like the 4.x branch is going to be out before we get a patch for this issue into 3.x.

That's fine with me. Thanks for fixing the PHP notices.

#13 Works for me. Thanks!

7.x-3.x is receiving critical fixes only.

For those in need, here is a reroll of the patch that applies to 3.23

This is fixed in 7.x-4.x.

Reroll of patch in #21 against the latest HEAD of the 7.x-3.x branch.