Closed (fixed)
Project:
Signup
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Sep 2011 at 15:39 UTC
Updated:
8 Mar 2012 at 17:20 UTC
Jump to comment: Most recent file
It was reasonable in the past to go from 4.7.x straight to 6.x. It's no longer reasonable/possible to do that from 6.x to 7.x. I think this module should remove all hook_updates below 6000 (and maybe below 6005) and add some upgrade text that reminds users to use a very recent version of 6.x before updating to 7.x.
The particular motivator for doing this from my perspective is that signup_update_5203 and signup_update_5204 contain queries which are flagged as "critical issues" in coder reviews. There are other ways to address that (like creating an "ignore" file) but that seems equally hacky.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | signup-remove-old-updates-1286454-3.patch | 13.55 KB | jordojuice |
Comments
Comment #1
ezra-g commentedI support this. This is also consistent with the recommendation at http://api.drupal.org/api/drupal/developer--hooks--install.php/function/... "A good rule of thumb is to remove updates older than two major releases of Drupal. See hook_update_last_removed() to notify Drupal about the removals."
Comment #2
dwwNo objections. Fire at will. ;)
Thanks,
-Derek
Comment #3
jordojuice commentedRemoves all
hook_update_N()implementations before 6000.Comment #4
sgabe commentedCommitted, thanks!