Because modernizr.min.js is not maintained by this module it should be moved to sites/all/libraries. As a best practice all third party libraries should be outside the modules directory.

CommentFileSizeAuthor
#1 move-modernizr.min_.js-1278842-1.patch1.17 KBiler

Comments

iler’s picture

iler commented
StatusFileSize
new move-modernizr.min_.js-1278842-1.patch1.17 KB

I created a patch for this one. Also added check to see if the modernizr.min.js really is in sites/all/libraries/modernizr/ directory. If the file isn't there user will get a warning message displayed in the admin area of Modernizr module.

tamasd’s picture

tamasd commented
Category: task » bug

The libraries support was there, the problem was that I forgot to modify the code in hook_init().
This is fixed in commit: f8cbc8343d716af9ac2e65a50749f4bc7b37f48f.

rupl’s picture

rupl
he/him
Primary language English
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

...why was this opened if we have #999870: Use the Libraries module? Or perhaps there was need to solve this in a per-branch basis by opening two separate issues (one for 7.x + one for 6.x)?

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Status: Active » Closed (fixed)

The new 7.x dev seems to work just fine, but there is one minor WTF...

The site status displays "Modernizr is installed and ready to use" (it also detects 2.0.6 as version) even though I remove the modernizr.js file from the ../sites/all/libraries/ directory or the whole directory altogether?!?

...don't mind me. There was some caching mechanism implemented since the last dev I was using. Crealing caches made the status "complain" as expected ;)

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Status: Closed (fixed) » Active
klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

...sorry for the noise.