I'm building a simple custom module which does some retweeting and I needed to add a retweet class to this module. I figured it's probably a decent addition, so here's a patch.

CommentFileSizeAuthor
#8 twitter-n1275440-8.patch1.07 KBdamienmckenna
twitter_retweet.patch1.1 KBultimateboy

Comments

ultimateboy’s picture

ultimateboy commented
Status: Active » Needs review
juampynr’s picture

juampynr commented
Assigned: ultimateboy » Unassigned

I look forward for a review of this patch and another patch for the 6.x-3.x branch.

@ultimateboy, how do you use this? Is there any code that enables a user to retweet? If it is useful it could be nice to add it to the module too.

13rac1’s picture

13rac1 commented
Version: 7.x-3.x-dev » 7.x-5.x-dev

Code needs work and update to 5.x. Plus, functionality needs UI.

$ git apply twitter_retweet.patch 
twitter_retweet.patch:32: trailing whitespace.
  
twitter_retweet.patch:42: trailing whitespace.
 
error: patch failed: twitter.inc:111
error: twitter.inc: patch does not apply
error: patch failed: twitter.lib.php:147
error: twitter.lib.php: patch does not apply
13rac1’s picture

13rac1 commented
Status: Needs review » Needs work
ultimateboy’s picture

ultimateboy commented

Truthfully, I have no idea why I needed this or how I used it back then - it's been too long.

If you feel it's something worth adding to 5.x-dev, please do so, otherwise, close the issue. IMO, just the API would be beneficial. I personally wouldn't "require" that a UI be present.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, twitter_retweet.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new twitter-n1275440-8.patch1.07 KB

Rerolled. I think ;)

DamienMcKenna queued 8: twitter-n1275440-8.patch for re-testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.