When you commit a change with the --author argument the commit doesn't show on your commit log, instead it shows on the commit log of the author. It would be great if it could show on both pages.

I'm not sure which project this belongs to, feel free to move around as appropriate.

Comments

hefox’s picture

Subscribe.

I check how active the project is by looking at commiters block; if that's dead I'll not realize commits are being done by other authors that aren't commiters.

marvil07’s picture

Assigned: Unassigned » marvil07

Taking a look at this.

marvil07’s picture

Assigned: marvil07 » sdboyer
Status: Active » Needs review
StatusFileSize
new4.15 KB

IMHO it's a good idea to show the activity as both, author and committer in the same place, on that default view.

I have a patch that does it in this way:

  • Create a special views argument handler to catch author_uid and committer_uid with an OR.
  • Modify commitlog_user_commits default view to use the new argument.

This would naturally would need a change on other realted versioncontrol operation views in other project(for d.o use: vc_project_user_commits and vc_git_project_user_commits on versioncontrol_project project).

Anyway, this is change in a the logic. @sdboyer, would you agree with this change?

I check how active the project is by looking at commiters block; if that's dead I'll not realize commits are being done by other authors that aren't commiters.

@hefox: I guess that's another issue, and it's not actually about versioncontrol project itself. I just wanted to mention that if you go to the "View commits" link on the "Development" block at the project page of the module, you should actually see all commits in the associated repository.

marvil07’s picture

Assigned: sdboyer » Unassigned
Status: Needs review » Fixed

commushed

Now I will open a related issue on versioncontrol_project

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 6b28b10 on 6.x-2.x, repository-families, drush-vc-sync-unlock by marvil07:
    Issue #1259724: Allow commits to be seen in commit log of both the...

  • Commit 6b28b10 on 6.x-2.x, repository-families by marvil07:
    Issue #1259724: Allow commits to be seen in commit log of both the...