UC Quote module already defines i18n_variables, but as the related settings form doesn't go through system_settings_form(), the i18n module has no grip on those variables. And thus, they don't get translated.

I created a patch to fix this, although I agree with TR and firewing1; it would be better to "fix" i18n, as they state in #896436: Shipping quotes and credit card information strings do not show multi-lingual description message

But for now, the patch will do, for me.
Losing formatting options for those 2 fields isn't really a loss, for me.


#4 1257488-uc_quote-i18n-settings.patch7.5 KBlongwave
PASSED: [[SimpleTest]]: [MySQL] 2,081 pass(es). View
ubercart-make_shipping_i18n_variables_translatable.patch7.31 KBPieterDC
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch ubercart-make_shipping_i18n_variables_translatable.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots. View


Status: Needs review » Needs work

The last submitted patch, ubercart-make_shipping_i18n_variables_translatable.patch, failed testing.

PieterDC’s picture

Ps: losing formatting options is not required to fix this issue.
We can have both at the same time, cfr. uc_cart_checkout_messages_form()

Be my guest to adjust the patch...

mgifford’s picture

longwave’s picture

Version: 6.x-2.6 » 6.x-2.x-dev
Status: Needs work » Needs review
7.5 KB
PASSED: [[SimpleTest]]: [MySQL] 2,081 pass(es). View

This patch is based on #0 but keeps the format options in place.

longwave’s picture

Status: Needs review » Fixed

Committed #4.

In 7.x-3.x variable translations are significantly different, so this will be fixed in #1533286: Add support for Variable module

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.