Add better views filters for star ratings

Patches are welcome. Even proper git patches are welcome so you can get the proper commit credit. But we just changed a lot regarding the field and the widgets so patches would be simpler to work with. Sorry :(

Marking as wont-fix. Patches are always welcome :)

AWESOME!!!

I'm testing this out. Thanks.

Great job guys! This works great!

The patch didin't work for me.

field_info_field($this->definition['field_name']) does not pull the configuration setting for the number of stars for the field. That setting is stored in field_config_instance and you get it by using field_info_instance. However, field_info_instance takes both the entity_type and bundle_name for the field along with the field_name for arguments. I had a bit of trouble figuring out how to get that info, so the solution I have is a bit hacky but seems to work. Basically, I get the field_info and entity_type from the field_info_field by doing some hacky stuff the the bundles array. Then, I call field_info_instance to get the number of stars configured for the field.

Let's try that again...

And again...

And again again...

This should work now. I'm patching against 7.x rather than alpha 2.

This is becoming comedic...if this doesn't work, I don't know what will.

@anemirovsky well then good thing that one work ;-p

I'll review this this weekend.

Thanks for your hard work :)

Patch from #19 worked for me thank you!

#19 worked for me except for selecting "No stars". Evidently the result of no stars is blank (or null), not zero.

This is a tougher problem to solve. There isn't actually a row created for the fivestar field if the value is no stars, so the Views query fails to find those nodes because it's looking for a row in the fivestar field's table.

One way I thought of to try to fix this is to modify the Views query if the selected filter option is 0 to not add the where clause that looks for a value in the joined field table. Instead it will add a where clause that checks that the node doesn't have a corresponding row in the field table, since if it doesn't appear there, the rating for that node must be 0. However, there are some serious performance issues with that, so I don't really think that's a good choice.

To be honest, I'm not sure what the best option is here. Ideally, the fivestar module would record a 0 rating for the node if the node has no stars, but I don't know how feasible that is.

Is it possible to modify the query it to do a left join and change the where to test for "zero or null" (test for both, I mean)?

Try this one on for size. It's not the prettiest code I've written, but I tried to err on the side of understandable logic rather than minimal lines of code. This should handle the No Stars use case for multiple values in the filter as well as for the "Is one of" and "Is not one of" operators.

I installed patch #26. I'm able to add the exposed filter to my view just fine, but it doesn't seem to select the correct nodes.

My filter is defined as a single filter, with operator = "is one of", and the default options (Select all, No stars, 1 star, 2 stars, etc.).

I have a view that (unfiltered) returns 30 nodes with average votes ranging from 2.1 to 4.8.

Select "No Stars" - I get no results (as expected).
Select "1 Star" - I get 3 nodes, with averages of 2.3, 2.3, and 3.1.
Select "2 Stars" - I get 3 nodes, with averages of 3, 2.9, and 3.1.
Select "3 Stars" - I get 5 nodes, with averages ranging from 2.8 to 3.5.
Select "4 Stars" - I get 5 nodes, with averages of 3.6 for one node, and 4 for the other 4 (1 vote each).
Select "5 Stars" - I get 14 nodes, with averages ranging from 2.1 to 4.8.

My guess is that if any single vote on any node matches the selection, the node is shown. If that's the case, that's counter-intuitive to what users would expect, IMO.

If I filter on "3 Stars", for example, I would expect to see all nodes with an average rating from 3 to 3.9.

Is there a way to get this patch to accomplish that?

#26 fails to patch for Fivestar 7.x-2.1 with the following error:

patching file fivestar.info
Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED -- saving rejects to file fivestar.info.rej
patching file fivestar.module
Hunk #1 succeeded at 136 (offset 15 lines).
patching file includes/fivestar.field.inc
Hunk #1 succeeded at 125 (offset 15 lines).
patching file includes/fivestar_views_handler_filter_in_operator.inc

inside fivestar.info.rej:

--- fivestar.info
+++ fivestar.info
@@ -6,3 +6,4 @@
 configure = admin/config/content/fivestar
 files[] = test/fivestar.base.test
 files[] = test/fivestar.field.test
+files[] = includes/fivestar_views_handler_filter_in_operator.inc

In views, you the "Broken/Missing handler" error and are unable to use the filter.

Rerolled aganst 2.1.

Removed the "is empty"/"is not empty" operator options for better UX (they're covered by the "0 stars" option).

Replaced the four massive, nested, "if" statements and replaced them with more nimble conditions.

Fixed fivestar_field_views_data to not use the title for identification.

Removed unintended whitespace fix.

Hi,

I tried the patch in #31, using latest dev version: 7x-2.0+5
I get this error (in views, I have BEF enabled)

(Products referenced by field_product) Broken/missing handler (= )

I'm using Fivestar on products inside Drupal commerce if that matters at all.

Thanks for the great work

Okay, using the patch in drush make doesn't seem to work. Looks like it chokes on the lines that the packaging system adds to the info file.

New patch that moves the added lines a few up. Also seems more "right" to have includes before tests.

Doh, missed a file.

Patch #35 is working for me.
Thank you.

Patch works but I got following error in drush:

Patch #35 failed:

Hunk #1 Failed at 4 Saving rejects to fivestar.info.rej

Removed

Patch #35 always selects "no Stars" when using grouped filters even when deselected.

Rerolled against 7.x-2.2.

+++ b/includes/fivestar_views_handler_filter_in_operator.inc
@@ -0,0 +1,66 @@
+      $or_statement->condition("$this->table_alias.$this->real_field", NULL, $nul_operator);

"IN" condition works fine after applying the patch but for "NOT IN" view will display all the results.
As query contains:
WHERE (( (node.status = '1') AND( (field_data_field_rate.field_rate_rating NOT IN ('0', '20', '40', '60', '80', '100')) OR (field_data_field_rate.field_rate_rating IS NOT NULL ) )))

And data will pass through this filter, as it is NOT NULL.

I am working on this issue.

+++ b/includes/fivestar_views_handler_filter_in_operator.inc
@@ -56,11 +57,57 @@ class fivestar_views_handler_filter_in_operator extends views_handler_filter_in_
+    if ($this->operator == 'in') {
...
+    if ($this->operator == 'not in') {

May be we could convert this in a switch case. It looks nice! It is only a suggestion not necessary though :)

+1 bump

This feature introduced to have a filter handler inside view. This patch handles both "IN" and "NOT IN" conditions to filter out the correct set of data.

Working as per expectations !

Issuing RTBC

Thanks for the patches and reviews everyone !!!

I use the filter because I simply want to filter (exposed) voted from unvoted nodes. When configuring the filter I can choose 1star, 2stars, ... BUT there is a "No star" setting that ALWAYS gets set automnatically when saving the filter making it useless?

EDIT: I use a grouped filter (seems to work on a single filter) with three (desired) options (Any, NOT IN NO STARS, IN 1..6 STARS)