Nodetitle plugin type selection and title processing broken [Patch provided] [#1253878]

If you restrict your nodetitle search to a specific content type, you end up with no titles ever working, because of a logic error in the nodetitle plugin. In a similar (but unrelated) logic error, the nodetitle plugin ignores the title text you specify and always uses the node title. The attached patch fixes both issues.

Comment	File	Size	Author
	fl_nt.patch	755 bytes	pje

Comments

Comment #1

morenstrat

he/him

German

Bochum, Germany

commented 19 August 2011 at 19:30

Version:

6.x-3.1

» 6.x-3.2

The first hunk of the patch made it to version 3.2. The second hunk however didn't. The described problem persists.

Comment #2

pje commented 22 August 2011 at 05:43

Unfortunately, another part of the change to 3.2 puts back in the same problem for me:

// construct values for link
- $title = $target['text'] ? $target['text'] : $target['dest'];
+ $title = $target['text'] ? $target['text'] : $node->title;

The above change turns nice inline links that reference [[a page here]] into "A Page Here", which disrupts the capitalization of the sentence the link is contained. So, even though part of my patch was included, the hunk above effectively reverts it, as I must *still* write "[[a page here|a page here]]" in order to get the desired behavior.

So I had to revert the above part of the change in order to get back to the desired state, which is to allow users to mark up terms in existing sentences on wiki pages, without having to double the text to get the desired capitalization. (That is, simply adding the brackets around a piece of text should not alter the text, but rather, just make that text a link.)