I was about to write documentation on buttons in Drupal when I noticed quite a number of inconsistencies, for one that we introduced a .div somewhere which resulted in the removal of our last blue button.

CommentFileSizeAuthor
#11 unblue-1238124-11.patch573 bytesDavid_Rothstein
#2 save_button_blue_again.png12.87 KBBojhan
bringing.back_.the_.blue_.patch464 bytesBojhan

Comments

Bojhan’s picture

Bojhan commented
Status: Active » Needs review

My first d8 patch, lets see.

Bojhan’s picture

Bojhan commented
Issue tags: +Usability
StatusFileSize
new save_button_blue_again.png12.87 KB

save_button_blue_again.png

aspilicious’s picture

aspilicious commented

Very strange that you find this now. I never saw these blue buttons and I'm looking at drupal 7 since januar 2010. Code wise this looks ok but I wondering why someone removed the blue.

Bohjan checked the contrast and it was ok.
Strange... very strange...

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Yay blue buttons.

ksenzee’s picture

ksenzee
she/her
commented

I had forgotten about the blue button! Looks great.

Tor Arne Thune’s picture

Tor Arne Thune commented

I've never seen these blue buttons before in D7, but they look good to me.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Wow I had never seen that before in D7...

I'm a little sad we can't make this CSS re-usable for the 'default' button on any form.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x. Thanks.

Bojhan’s picture

Bojhan commented
Status: Fixed » Needs work

@Dries Angie said it should probably not be committed to D7 for the sake of freaking out users(mostly content editors) with their buttons suddenly changing.

I don't mind either way, most probably won't notice anyway.

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented

Thank you for bringing in the blue button. I like it very much.

However, it have a side effect:

We are under the impression that the Preview button is disabled. :-)

David_Rothstein’s picture

David_Rothstein commented
Title: The blue 'save' button is gone, bring it back! » The blue 'save' button is gone, bring it back! (or take it away again)
Status: Needs work » Needs review
StatusFileSize
new unblue-1238124-11.patch573 bytes

Here's the rollback patch, since a similar change was rejected as too late for D7 in December (#544398: Delete buttons look disabled in Seven theme even though they're not). I went ahead and removed the CSS rather than a straight rollback since it previously had no effect anyway and was kind of broken even if it did ("#edit-submit-1"???).

I think this could be rolled back for D8 too, since it's a half-step which introduces an inconsistency. Do we really want blue save buttons on the node form, but save buttons everywhere else a different color? Bojhan already started an issue at #1238484: Ability to mark the form buttons to be of a specific type (so that they can be styled differently) to try to use the "blue" pattern everywhere and that's where further work can happen on doing this in a consistent way.

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented

I really like the new Blue button. I'd just remove it only in D7, though. For D8, we need to find a balance between blue buttons and the other ones.

We should investigate using a blue label on all button using a similar shade of blue for the Save button we are trying to introduce. So, for example, in #2, make the Preview button label a shade of the blue Save button.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Will the patch still work if the primary button is not the first button in the form (see performance configuration page), or if the submit button has a different #name than "submit"?

Bojhan’s picture

Bojhan commented
Version: 8.x-dev » 7.x-dev

Lets continue the discussion about d8 in the other issue, I don't think it needs a rollback necessarily for D8. It's a good motivator to make it more consistent :)

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented
Status: Needs review » Reviewed & tested by the community

RTBC for the rollback in D7.

@Bojhan: Will you create the issue for D8?

Bojhan’s picture

Bojhan commented

#1238484: Ability to mark the form buttons to be of a specific type (so that they can be styled differently) already did :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Version: 7.x-dev » 8.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks, David. Yeah, I shudder to think of some 100K site owners' clients all e-mailing them at once asking "WHY ARE OUR BUTTONS BLUE??!?!" :P Nice improvement for 8.x though!

Committed and pushed the rollback to 7.x. Marking back to fixed for 8.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

I'm sad this won't be in D7 since I'm the one who poked Bojhan in IRC and said "Hey, what happened to our blue buttons from d7 alpha?" They were "removed" in D7 only because a form ID was changed which broke Seven's CSS, but I agree with the new D8 issue more than I disagree with this issue.