Closed (fixed)
Project:
Email Field
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
28 Jul 2011 at 06:22 UTC
Updated:
31 Jan 2012 at 23:05 UTC
Jump to comment: Most recent file
Comments
Comment #1
Bevan commentedThis patch was based on a related issue: #943140: Support migration into phone fields
Comment #2
mikeryanSubscribe
Comment #3
mh86 commentedI haven't been using Migrate yet, so I can't review your patch. As soon as someone tests and reviews it, I'm willing to commit it.
Comment #4
invisibleink commentedThis patch worked beautifully for me. Solved my migration hang-up both for migrating and rolling back.
Brilliant! Thanks.
Using: Migrate 7.x-2.2-rc1 and Email 7.x-1.0-beta1
Comment #5
das-peter commentedThanks Bevan.
I've re-rolled the patch to use the path
a/instead ofa/app/sites/all/modules/contrib/email/in the patch and changedImplementation of hook_migrate_api()to the new standardImplements hook_migrate_api()..And of course I gave it a try - it works like a charm.
Thus marking as RTBC.
Comment #6
Bevan commentedThanks das-peter! :)
(I have since realised my patches were non-standard and also learned how to generate drupal standard patches from non-drupal git repos:
git diff --relative=app/sites/all/modules/contrib/email ...)Comment #7
mh86 commentedCommitted patch from #5. Thanks for the patch and reviews!
Comment #8
wusel commentedIt is necessary, to disable, then to delete and then to enable my migration-import-module.
Then all is ok.
Thank you very much.
Comment #9
wusel commentedComment #11
victoriachan commentedHi,
Thank you Bevan, for creating the patch, and thank you, mh86 for committing it to dev.
I'm just re-rolling the patch to work with version 7.x-1.0 for people who might need to use it with 1.0 now.
Cheers,
Victoria
Comment #12
wusel commentedComment #13
Bevan commentedwusel, why did you reopen?