Closed (fixed)
Project:
Panels
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
26 Jul 2011 at 19:53 UTC
Updated:
16 Jun 2014 at 16:29 UTC
Jump to comment: Most recent, Most recent file
While working on panels-tabs I've implemented panels_tabs_panels_pane_content_alter(), where I need to get the $display (to get the the regions that should be themed as tabs).
As panels_tabs_panels_pane_content_alter() doesn't get the $display object itself, currently I need to use panels_load_display(), however panels_load_displays() doesn't statically cache the loaded $display, so I'm hammering the DB with those display loads.
So I think we have two options. Pass also the $display in the later hook, or statically cache the display. Which one do you think is better?
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 1230324-pass-panels-diaply-3.patch | 774 bytes | amitaibu |
Comments
Comment #1
Letharion commentedNeeds a reply from merlin :)
Comment #2
merlinofchaos commentedWe can probably pass the display as an additional argument. That shouldn't break anything that exists. That should be an easy patch.
Comment #3
amitaibuNo API change with patch.
Comment #4
merlinofchaos commentedCommitted.