I've reorganized some code too. The function could use a better name.

CommentFileSizeAuthor
#2 advagg-1202396-2.patch4.89 KBmikeytown2
#1 advagg_url.patch2.37 KBkilles@www.drop.org
advagg_url.patch2.37 KBkilles@www.drop.org

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented
StatusFileSize
new advagg_url.patch2.37 KB

Oops, the previous patch had an error.

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new advagg-1202396-2.patch4.89 KB

Do you see any issues with placing the auth logic outside of ($ip == -1)? I've also added in the port number as well. Changed $_SERVER['PHP_AUTH_pw'] to $_SERVER['PHP_AUTH_PW'] as I believe this is a typo. Replaced all calls that have similar logic with a call to _advagg_build_url()

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Active

committed everything but the port number stuff; it is commented out.

mikeytown2’s picture

mikeytown2 commented
Status: Active » Fixed

eh, going to mark this as fixed. I can enable the port code if someone opens up an issue

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.