ER.module alters the password reset form help text to say "Enter your e-mail address. You'll be sent a new password immediately." This is not the case. Is it inappropriate text or a non-implemented feature?

CommentFileSizeAuthor
#6 pass_instructions-1197886-6.patch768 bytesgreggles
#4 pass_instructions-1197886-4.patch550 bytesdabblela

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

How is it "not the case" ?

What does happen?

dabblela’s picture

dabblela commented

A new password is not sent, it's the still the one time login link.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Confusing Password Reset Instructions » Make password reset instructions more generic
Category: support » bug

The default text includes a password. If your site doesn't then someone changed it.

This text could be changed to be more appropriate for more sites.

"Enter your e-mail address." is probably enough.

dabblela’s picture

dabblela commented
StatusFileSize
new pass_instructions-1197886-4.patch550 bytes

You're right, I think that's a strange core thing then.

dabblela’s picture

dabblela commented
Status: Active » Needs review
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new pass_instructions-1197886-6.patch768 bytes

Here's the language used in 7.x, what do you think of this?

Status: Needs review » Needs work

The last submitted patch, pass_instructions-1197886-6.patch, failed testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Needs review

#6: pass_instructions-1197886-6.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, pass_instructions-1197886-6.patch, failed testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I don't get it. In local testing this patch is fine.

http://qa.drupal.org/pifr/test/409593 says that the tests are passing fine.

I imagine that's a false negative on the tests on this patch for some reason.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Fixed

Now re-rolled and committed - http://drupalcode.org/project/email_registration.git/commit/168a8d2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.