Attached

CommentFileSizeAuthor
#14 1182374-8-coding-style-fixes-14.patch757 bytesadam_
#11 1182374-8-coding-style-fixes-11.patch1.2 KBSivaji_Ganesh_Jojodae
#8 1182374-8-coding-style-fixes.patch1.92 KBbrianV
#7 code-style-includes-filetransfer.patch1.94 KBlyricnz
code-style-includes-filetransfer.patch2.47 KBlyricnz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lyricnz’s picture

lyricnz CreditAttribution: lyricnz commented
Status: Active » Needs review
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

RTBC it is.

lyricnz’s picture

lyricnz CreditAttribution: lyricnz commented
Issue tags: +Needs backport to D7
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Just a note (saying here, but applies to all of these patches) that since this isn't a bug fix, it's going to have to wait until our critical bug count gets <= 15 again.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

code-style-includes-filetransfer.patch queued for re-testing.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Reviewed & tested by the community » Needs work

does not apply anymore

lyricnz’s picture

lyricnz CreditAttribution: lyricnz commented
Status: Needs work » Needs review
FileSize
code-style-includes-filetransfer.patch1.94 KB

Reroll. One of the fixes was applied already.

brianV’s picture

brianV CreditAttribution: brianV commented
FileSize
1182374-8-coding-style-fixes.patch1.92 KB

reroll

lyricnz’s picture

lyricnz CreditAttribution: lyricnz commented
Status: Needs review » Reviewed & tested by the community

Coming up on 2 years.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed to 8.x. Thanks!

Moving back to 7.x.

Sivaji_Ganesh_Jojodae’s picture

Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commented
Issue summary: View changes
Status: Patch (to be ported) » Needs review
FileSize
1182374-8-coding-style-fixes-11.patch1.2 KB

Patch for d7 has been attached.

parthipanramesh’s picture

parthipanramesh CreditAttribution: parthipanramesh commented
Status: Needs review » Reviewed & tested by the community

Looks fine!

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/427ae62

But the SSH fixes in the Drupal 8 patch could be backported too. Setting back to "needs work" in case anyone wants to take that on also.

adam_’s picture

adam_ CreditAttribution: adam_ commented
Status: Needs work » Needs review
FileSize
1182374-8-coding-style-fixes-14.patch757 bytes

I made the style adjustments to the 7.x equivalent of SSH.php, located at includes/filetransfer/ssh.inc

meeli’s picture

meeli CreditAttribution: meeli commented
Status: Needs review » Reviewed & tested by the community

Tested, looks nice. Yay!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

amitgoyal’s picture

amitgoyal CreditAttribution: amitgoyal commented
Status: Needs work » Needs review

14: 1182374-8-coding-style-fixes-14.patch queued for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

#14 is still RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

Status: Needs work » Needs review

dcam queued 14: 1182374-8-coding-style-fixes-14.patch for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

Status: Needs work » Needs review

dcam queued 14: 1182374-8-coding-style-fixes-14.patch for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

Status: Needs work » Needs review

dcam queued 14: 1182374-8-coding-style-fixes-14.patch for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

Status: Needs work » Needs review

dcam queued 14: 1182374-8-coding-style-fixes-14.patch for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

Status: Needs work » Needs review

lauriii queued 14: 1182374-8-coding-style-fixes-14.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

Status: Needs work » Needs review

mgifford queued 14: 1182374-8-coding-style-fixes-14.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

Status: Needs work » Needs review

mgifford queued 14: 1182374-8-coding-style-fixes-14.patch for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

Status: Needs work » Needs review

mgifford queued 14: 1182374-8-coding-style-fixes-14.patch for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

Status: Needs work » Needs review

mgifford queued 14: 1182374-8-coding-style-fixes-14.patch for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

Status: Needs work » Needs review

dcam queued 14: 1182374-8-coding-style-fixes-14.patch for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

Status: Needs work » Needs review

mgifford queued 14: 1182374-8-coding-style-fixes-14.patch for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: 1182374-8-coding-style-fixes-14.patch, failed testing.

Status: Needs work » Needs review

dcam queued 14: 1182374-8-coding-style-fixes-14.patch for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed e9bca3a on 7.x 
    Issue #1182374 by lyricnz, xendil, sivaji, brianV: Code style fixes for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.