Originally raised in #1155920: BEF needs to respect Views' new auto-submit functionality in the Better Exposed Filters queue. The attached patch would allow CTools auto-submit code to trigger on checkboxes and radio buttons as well as select and input elements.

CommentFileSizeAuthor
auto-submit.patch712 bytesmikeker

Comments

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mdupont’s picture

mdupont
Primary language French
Location Switzerland
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Closed (fixed) » Patch (to be ported)

It would be good to apply this patch to 6.x too. The code is exactly the same and applying the above patch worked for me™, allowing to use CTools auto-submit with checkboxes, for instance when using Better Exposed Filters and Views 3.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Patch (to be ported) » Closed (fixed)

#1324238: Not all views exposed forms auto-submit correctly (was: Clean up and improve auto-submit.js0 this one is better™ :þ

And the fix here is actually wrong.

mikeker’s picture

mikeker commented

@nod_, not exactly wrong... though not as elegant as your patch in #1324238: Not all views exposed forms auto-submit correctly (was: Clean up and improve auto-submit.js0. Unless I'm missing something?

Though this one has the advantage of being committed! :)

nod_’s picture

nod_
Primary language French
Location Lille
commented

I was talking about *[type!=input] I don't believe any element have a type=input so the selector actually match any DOM element. not just inputs.

mikeker’s picture

mikeker commented

Holy crap!

I'm not sure how I did that... It should be [type!=text], not [type!=input]. Fortunately, the binding for text elements follows the binding for everything, but nod_ is correct that this patch binds against an overly broad scope of elements.

Anyone following this or wanting it backported to D6 should take a look at #1324238: Not all views exposed forms auto-submit correctly (was: Clean up and improve auto-submit.js0, which also has a D6 patch.

Thanks for pointing that out, nod_