Give modules the chance to alter the created css array [#1178258]

I need this so I can make a drag and drop settings form in a submodule.

Comment	File	Size	Author
#3	fullcalendar-css-array-alter-work-warning-fix.patch	7.68 KB	aspilicious
	fullcalendar-css-array-alter-work.patch	7.68 KB	aspilicious

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

aspilicious CreditAttribution: aspilicious commented 3 June 2011 at 22:37

Link to module: http://drupal.org/sandbox/aspilicious/1175528

Comment #2

aspilicious CreditAttribution: aspilicious commented 3 June 2011 at 23:54

Status:

Active

» Needs review

Needz review :)

Comment #3

aspilicious CreditAttribution: aspilicious commented 4 June 2011 at 00:37

File	Size
fullcalendar-css-array-alter-work-warning-fix.patch	7.68 KB

New patch because an empty calendar throwed some notices at me while using the previous patch.. Those sneaky empty calendars...

Comment #4

santam CreditAttribution: santam commented 4 June 2011 at 01:59

Have applied the patch and it is working here without any notices or errors. The weights can be arranged and css processing gets changed based on that.

Comment #5

aspilicious CreditAttribution: aspilicious commented 5 June 2011 at 20:07

Tim I'm thinking about this again, maybe we should add the settings page to fullcalendar_color core. It would be less hacky. And we can handle the default colour thingie in a cleaner way.
But thats your call.

I also noticed that the drag and drop interface in the settings menu isn't rly that flexible as it rely on hooks. If I added multiple color options in the extension module I couldn't change the processing order of those colors as they were processed in the same module/hook. So for each color thingie their need to be one module. Thats why I'm thinking of renaming the module to "fullcalendar color classname" instead if extension as it would be stupid to add multiple color options in the same module.

Thats why I'm not that sure anymore hooks are the best solution for this. *If* plugins are going to be introduced into D8 I'm planning to investigate if we can convert the color stuff to a plugable system. That way each module can implement as many plugin implementations as they want. And I would make the drag an drop system as flexible as it can be. (if I get what they are planning to do :) )

(more D8 stuff)
AND last but not least, we need a way to shrink the number of secondary tabs. If for example I can work with the plugins and I write a dozen of color stuff plugins I don't want them all to be on top of the page. But maybe I should handle that in the D8 module...

Just thoughts so I don't forget them :)

Greets