Package contains .gitignore file [#1170366]

Comment	File	Size	Author
#7	devel-n1170366-7.patch	172 bytes	DamienMcKenna

#6	devel-clean_gitignore-1170366.patch	157 bytes	lunatic

Comment #1

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 27 May 2011 at 02:38

Should modules have their libraries in sites/all/libraries? I don't understand why it's installing it in the module directory.

Log in or register to post comments

Comment #2

moshe weitzman CreditAttribution: moshe weitzman commented 27 May 2011 at 03:07

If libraries module is present then drush installs firePHP to sites/all/libraries. Otherwise, it installes within devel package.

Am willing to change this if there is an alternate consensus.

Log in or register to post comments

Comment #3

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 27 May 2011 at 03:20

Assigned:

Unassigned

» Dave Reid

Writing patch to install to sites/all/libraries even if libraries.module is not enabled as that is reasonable before last-resorting to module directory...

Log in or register to post comments

Comment #4

drew reece CreditAttribution: drew reece commented 11 June 2011 at 23:27

I just spotted this .gitignore file.

Should modules be excluding files from peoples repo's? Is there best practice on this for Drupal? It seems to me like it should be 'repo/info/exclude'ed per repository so that it doesn't get distributed to all users.

Log in or register to post comments

Comment #5

joachim CreditAttribution: joachim commented 3 August 2011 at 16:20

Subscribing.

> Should modules be excluding files from peoples repo's?

I'm not terribly keen on a module making decisions about what I do with my project's git repo...

At the very least, if there's a very good reason for it, the .gitignore file should contain a comment explaining this very good reason.

Log in or register to post comments

Comment #6

lunatic CreditAttribution: lunatic commented 1 February 2013 at 09:15

File	Size
devel-clean_gitignore-1170366.patch	157 bytes

Hi,

I am attaching a patch that "cleans" the .gitignore file

I needed to include such a patch to my makefiles so as not to have to remove the devel's gitignore every time I was building my platform that was causing my git repo to include unnecessary files

Log in or register to post comments

Comment #7

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 1 February 2013 at 13:48

Version:	6.x-1.24	» 8.x-1.x-dev
Status:	Active	» Needs review

File	Size
devel-n1170366-7.patch	172 bytes

How about just removing the .gitignore file entirely?

Log in or register to post comments

Comment #8

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 1 February 2013 at 14:02

FYI the patch in #7 should apply to all branches.

Log in or register to post comments

Comment #9

pcambra

he/him

Spanish

Asturies

CreditAttribution: pcambra commented 17 February 2013 at 17:28

Assigned:

Dave Reid

» moshe weitzman

I'm up to not provide default .gitignore files, checking with Moshe :)

Log in or register to post comments

Comment #10

eloivaque

Catalan

Catalan Countries

CreditAttribution: eloivaque commented 9 March 2013 at 11:06

the patch of #7 it's working for me. The patch deleted the git ignore file.

Log in or register to post comments

Comment #11

commonpike CreditAttribution: commonpike commented 24 April 2013 at 16:04

The update manager refused to copy the dir because of .gitignore (debian) - left me alone halfway installation. everything had copied over except for the .info file. if that happens on more machines i would say its not minor ...