Closed (fixed)
Project:
Devel
Version:
8.x-1.x-dev
Component:
devel
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 May 2011 at 02:32 UTC
Updated:
27 Dec 2013 at 00:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dave reidShould modules have their libraries in sites/all/libraries? I don't understand why it's installing it in the module directory.
Comment #2
moshe weitzman commentedIf libraries module is present then drush installs firePHP to sites/all/libraries. Otherwise, it installes within devel package.
Am willing to change this if there is an alternate consensus.
Comment #3
dave reidWriting patch to install to sites/all/libraries even if libraries.module is not enabled as that is reasonable before last-resorting to module directory...
Comment #4
drew reece commentedI just spotted this .gitignore file.
Should modules be excluding files from peoples repo's? Is there best practice on this for Drupal? It seems to me like it should be 'repo/info/exclude'ed per repository so that it doesn't get distributed to all users.
Comment #5
joachim commentedSubscribing.
> Should modules be excluding files from peoples repo's?
I'm not terribly keen on a module making decisions about what I do with my project's git repo...
At the very least, if there's a very good reason for it, the .gitignore file should contain a comment explaining this very good reason.
Comment #6
lunatic commentedHi,
I am attaching a patch that "cleans" the .gitignore file
I needed to include such a patch to my makefiles so as not to have to remove the devel's gitignore every time I was building my platform that was causing my git repo to include unnecessary files
Comment #7
damienmckennaHow about just removing the .gitignore file entirely?
Comment #8
damienmckennaFYI the patch in #7 should apply to all branches.
Comment #9
pcambraI'm up to not provide default .gitignore files, checking with Moshe :)
Comment #10
eloivaquethe patch of #7 it's working for me. The patch deleted the git ignore file.
Comment #11
commonpike commentedThe update manager refused to copy the dir because of .gitignore (debian) - left me alone halfway installation. everything had copied over except for the .info file. if that happens on more machines i would say its not minor ...
Comment #12
damienmckennaCan someone please RTBC this?
Comment #13
cafuego commentedSure :-)
Comment #14
damienmckennaThanks! That's one more RTBC for the next release.
Comment #15
salvisPushed to D8 and D7. Thanks.