Improve usability and displayed information on the newsletter tab

This sounds useful and simple enough.

The newsletter tab currently displays a weird disabled, checked checkbox if sending has started/finished.

I imagine we could re-design the UI of the whole tab a bit. I'll try to get some input from our UX masters, posting some screenshots for them. (Updating title as well)

Note that the screenshots are with the patch from #497108: Send newsletter when node is published applied. and we should get that one in before working on this to avoid unecessary conflicts.

Some thoughts/goals (mainly for outsiders):

- For published nodes, we want to give users the possibility to send a a test mail (if the option is enabled, they can override the test mail address) and initiate sending of the newsletter
- sending will, depending on another global configuration either send immediately or just add them to a queue (called mail spool in simplenews)
- As a result, it would be useful to display that information to users directly.
- unpublished nodes have the option to initiate sending automatically when being published.
- We're not sure if sending should be possible at all if the node is unpublished, see linked issue above. So we could maybe use the same "send newletter" (however it's called and described finally) and just state that it will only be sent once the node is published
- Once sent, it would be useful to see some statistics/progress information. For example, while still being sent it would be useful to see how many mails have already been sent and how many still need to be sent. May be even with a progress bar but I'm not sure how important that is, a simple 140 / 1000 (14%) might be enough for now. Once finished, we just need to display how many mails were sent.
- It should also still be possible to send a test mail during/after the sending process.

Oh, we'd like to use the 'needs usability review' only for big 'controversial' stuff. 'Usability' is the catch-all tag :)

Ah, didn't know that about the tags :)

#1169990: Improve usability and displayed information on the newsletter tab is about adding a "Stop sending" button to this tab, I think it makes sense to keep that as a separate issue.

A simple mockup, thinking about the UI for this.

Just some ideas... see comments in the file.

This is the closest to what I am looking. In 6.x version there was an overview of all issues along with the spooling status (e.g. "2000/3000 newsletter sent"). I am looking for that information in the 7.x version but to no avail. Did I miss that or is it simply not present anymore?
If the latter is correct, I'd suggest to include that information for the newsletter tab.

You can find that on the Newsletters tab below Content.

Ok, I am not seeing the wood for the trees, could you please give the last part of the url?
When viewing the newsletter content and clicking the newsletter tab, I get what you see in screenshot 1.
On the configure pages (newsletters tab) I see screenshot 2.

NOTICE: My image descriptions have not been saved and I can't edit them no more. snews.png is "Screenshot 1" while snews2.png is "Screenshot 2".

admin/content/simplenews

Thanks a lot, I totally missed that tab there.

As Berdir suggested in #6, the radios are removed now, instead two fieldsets added (see screenshot).
First attempt.submitting for a review.

sent message and pending message modified (see screenshots)
The pending count and sent count added.
awaiting feedback.
Working on tests meanwhile.

+++ b/src/Form/NodeTabForm.php
@@ -232,7 +222,10 @@ class NodeTabForm extends FormBase {
-    if ($values['send'] == SIMPLENEWS_COMMAND_SEND_NOW) {
+    if($trigger['#name'] == 'send_test'){
+      simplenews_send_test($node, $form_state->get('test_addresses'));
+    }
+    if ($node->isPublished() && $trigger['#name'] == 'send_now') {
       simplenews_add_node_to_spool($node);

I would recommend to make separate submit buttons, instead of this. Should become easier to read. three submit buttons, for test send, send now and send published, change submit callback dynamically on the send button.

Separate submit methods added for each submit button. send newsletter submit button dynamically calls the submit handlers.

UI improved as discussed with Miro.

forgot to add this in #22

Message in the send field improved a bit. suggested as Berdir
did minor refactoring and ordering of elements.

Tests corrected. Message in send changed. ;)

Tests are already there for sending the actual and test mails, testing messages and UI.
I just changed the existing tets according to the changes made to the UI.
providing some fixed and admin theme added to the newsletter page with this patch.

and this is how it looks like (with the scheduler).

The button texts changed.

Button text change caused the test failures. Tests fixed accordingly.

Reworked on Miro's earlier changes and above comment.

As discussed with Berdir.
Minor UI fixes.

Send button declared separately for published and unpublished status of the newsletter.
As discussed with Berdir.
(interdiff against #29 added)

Some cleanup.

Committed and pushed.