Logout fails on Firefox

Some more on this:
I ended up having to put

if(FB.getSession() != null){
			return false;
		}

instead of just return false;
Otherwise clicking the logout link as a user that was registered normally, would return false also, and not go to the /logout page.

That works fine for me. We're using it on a site which is going for client testing + approval soon, so I'll let you know of any issues found with it!

One thing I did need to add is that it doesn't redirect properly after logging out. Drupal normally redirects to the homepage, so for now the attached patch does this. Note that it doesn't do anything with a destination currently, which it probably ought to, but that's a secondary problem.

Do you mean so it looks like this?:

// click handler
FB_Connect.logoutHandler = function(event) {
  if (typeof(FB) != 'undefined') {
    FB.logout(function () {
      // Logged out of facebook.  Need we act on this?
      window.location = Drupal.settings.basePath;     // <--- ADDED LINE
    });
    // Facebook's invalid cookies persist if third-party cookies disabled.
    // Let's try to clean up the mess.
    FB_JS.deleteCookie('fbs_' + FB._apiKey, '/', ''); // app id
    FB_JS.deleteCookie('fbs_' + Drupal.settings.fb.apikey, '/', ''); // apikey
  }
  if (FB.getSession()) {
    // Facebook needs more time to log us out. (http://drupal.org/node/1164048)
    return false;
  }
};

...because unfortunately that doesn't work :-/

I think see what you mean, that facebook won't yet have logged you out - but in using the patch from comment #5 above, I don't get that problem - Could facebook continue logging me out while window.location changes? If so, it wouldn't necessarily be a problem.

I mean the line is never reached.
But, sorry, you're right that the patch in #5 can send the user to a new page before logout finishes.
So I guess that means the main original issue of not being able to logout is fixed by your patch in #4. However, can we find a solution that also ensures the redirection on logging out (either to the front page, or to any destination in the querystring) does eventually happen?

Ah, I didn't mean to change the status.

subscribe

Drupal for Facebook v. 6.x-3.0-rc13
Firefox 4.0.1 on OSX

"return false" didn't work for me while commenting out line 20 solved my problem.

subscribe.

#7 + #11 fixed the issue for me in Safari and FF on Mac.

Chrome, Mac, as well.

Sorry I hadn't replied sooner - bit late not, but yes, it works in FF & Chrome on Ubuntu too. I haven't heard any problems from our client either. Thanks very much Dave :-)

Hi,

I had this problem myself on a new site. I am using the latest dev, but i didn't work for me. To get around this problem I added at top of fb_connect.js:

$(document).ready(function() {
$('.logout-button').click(function() {
FB.logout(function(response) {
// user is now logged out
});

alert("Du vil nu blive logget ud");
window.location = Drupal.settings.basePath;
});
});

Yes, yes - I know - it is embarissing that I had to add such a function, but now it works at least. Normally I wouldn't add such a code to save myself the embarrassment, but I hope some others will find this as a quick fix.

I will work on a better solution and hope to have it done by the end of this month.

Rino André Johnsen
rino@nymedia.no
Ny Media AS - www.nymedia.no

Has this change made it to drupal 7? I'm having this issue on a d7 site.

Instead of commenting out line 20 as per the beginning of the thread, what worked for me was to add a leading slash to the logout path:

jQuery("a[href^='" + Drupal.settings.basePath + "/user/logout']", context).click(FB_Connect.logoutHandler);

So "/user/logout']"...etc, instead of "user/logout']", ie.

I don't know if this is still relevant, but I was having this logout problem in firefox for the home page in Drupal 7.

I fixed it by installing the automated Logout module and setting a fast logout time (60 seconds)

For some reason this fixed the problem - I can now logout using the button or waiting for the automation.

-mafio