Hi,

Not been here long and am testing a few things at the moment, but i noticed that the point transaction page for the user(view?) that was fixed in 7.x-1.0-beta2, now appears to be back in the rc1 version,

hope it helps.

ps, hope i wasn't supposed to post this in the other thread to do with v6 version as it seemed rather version specific.

thanks and keep up the good work.
-kg

CommentFileSizeAuthor
#9 1163564.patch1.47 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Component: Code: userpoints_views » Code: userpoints
Status: Active » Postponed (maintainer needs more info)

It doesn't wsod for me so your bug report doesn't provide me with much information. Make sure you clear all caches and rebuild the menu (run update.php). If it still fails, try to figure out the actual error, see http://drupal.org/node/158043

kokrull’s picture

kokrull commented

hmmm, me then.? bummer, was hoping i found something, nevermind. lol

ok, the details
error reporting on, machine on same network, running wamp, but edited index.php and added code temporarily anyway.

deleted beta (which i had reverted to), placed rc1 version in its place. Ran update.php and got no pending. Went to devaddy/myuserpoints/1 and got wsod still. I was expecting an error of some kind due to previous edit, but nothing. Then remembered i had left the admin menu module left on, they seem to clash, (the admin menu doesn't appear while userpoints nodes and comments is enabled, but as i only use it for minimizing the modules and permissions page it wasnt a biggie for me, see http://drupal.org/node/442560#comment-4321346) I switched it off and went back to myuserpoints/1 the page was displaying, but no points were displayed, but did get the following notices,

Notice: Undefined index: 1 in userpoints_filter_query() (line 1402 of *snip\sites\all\modules\userpoints\userpoints.module).
Notice: Undefined index: 1 in userpoints_filter_query() (line 1402 of *snip\sites\all\modules\userpoints\userpoints.module).
Notice: Undefined index: localized_options in menu_navigation_links() (line 1780 of *snip\includes\menu.inc). (hmm, looks like i got another unrelated issue aswell, )

soz if i posted in the wrong place, kinda new, but thanks for getting back to me.

cheers, k/g

edit
i also seem to have a extra menu item appear on the myuserpoints/1 page, shows as "My !points" it only appears on that page and no others and links to myuserpoints/%25 which again doesnt show the points, hitting the regular "my points" menu displays all points normally,

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

You probably just want to use /myuserpoints. /myuserpoints/1 has a different meaning now, it doesn't show the points of the user 1 but the points of the current user of category id 1. So if you don't have any categories, then you get these errors.

Maybe your menu items are messed up, check them in the menu administration and tell me where they point to.

To access the points of another user, go to his user profile page and then chose the Points local tasks (or user/id/points).

kokrull’s picture

kokrull commented

all the menu items appear to be fine and do what they are supposed to do, can see my points menu and the link displays my points earned, its just the transactions page from the "view point transactions" link on the user profile, not a menu i have come across so not altered it, no idea why it points to the wrong place then,

when i go to edit the "my points" menu it says the path is "My !points" (which is the extra menu item that appears on the page that the transactions link points to) even though the hover text points to "myuserpoints/"

all worked fine with beta including the transactions, apart from the update changed nothing, anyways, my brains fried for the moment so going to go eat and look at it later,

thanks again for the input.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 7.x-1.0-rc1 » 7.x-1.x-dev
Status: Postponed (maintainer needs more info) » Active

Ah, I see. I didn't get from your two previous descriptions that this was about the link displayed on the user profile.

I guess we forgot to convert that link on the user profile. We have too few automated tests:(

I'll fix that soon, trivial stuff.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: 7.x-1.0-rc1 view point transactions wsod returns » Wrong "view transactions" link on user profile
restyler’s picture

restyler commented

I get the wrong link /myuserpoints/1 on user profile page (user/1), and that causes undefined index errors, too. 7.x-1.0-rc1

anewman1980’s picture

anewman1980 commented

Easy solution

Configuration -> Account Settings -> Manage display

then hide it. Do you really need it in the user profile anyway? The formatting of the profile content could also could do with an extra carriage return at the bottom.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new 1163564.patch1.47 KB

Try the attached patch, should fix both the wrong link and move the Points local task behind "Edit".

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jensen9090’s picture

jensen9090 commented

thanks a lot. the patch is good.