Comments

senpai’s picture

Title: Upgrade the cod_community Feature to D7. » Upgrade the cod_community Feature to D7
sirkitree’s picture

Assigned: Unassigned » sirkitree

starting work here.

sirkitree’s picture

StatusFileSize
new57.72 KB

This is a basic upgrade without the menu item. I couldn't understand why the menu item was exported since the view provides it... seemed weird to me.

The one other thing that seemed weird was the view in D6 (attendees) had the Signup relationship within it, but the relationship wasn't used. I used it in this version as a filter on if the person has attended or not. If there was a decision against this at some point I didn't find it, makes sense to me that there be a filter on the displays.

sirkitree’s picture

Status: Active » Needs review
oadaeh’s picture

Status: Needs review » Needs work

The patch doesn't apply anymore. I can try and work on it later, but my focus right now is #1293870: BoF Scheduling tool

druroot’s picture

Status: Needs work » Needs review
StatusFileSize
new59.27 KB

Here's a rerolled patch thats based mostly on #3. I editing the previous patch so it would apply for the most part then added back a few of the exposed filters that didn't make it through and rerolled. I think the patch is still missing a field and filter for interest, which I think it missing from base, but that's a separate issue.

coltrane’s picture

Status: Needs review » Needs work

#6 doesn't apply to 7.x-1.x for me

patching file cod_community/cod_community.features.inc
patching file cod_community/cod_community.features.menu_links.inc
patching file cod_community/cod_community.features.user_permission.inc
patching file cod_community/cod_community.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file cod_community/cod_community.info.rej
patching file cod_community/cod_community.module
patching file cod_community/cod_community.views_default.inc
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file cod_community/cod_community.views_default.inc.rej
druroot’s picture

Status: Needs work » Needs review
StatusFileSize
new60.02 KB

Rerolled against 7.x-1.x

oadaeh’s picture

Here are some things I found:

  • The Feature has a dependency on the Profile module, which is no longer available.
  • For the view:
    • There is default sorting in the page view that is not in the D6 version.
    • The D7 version is missing an exposed filter on "Job title" in the page view that is in the D6 version.
    • The D7 version is missing an exposed filter on "Interests" in the page view that is in the D6 version.
    • The D7 version is missing a field on "Job title" in the page view that is in the D6 version.
    • The D7 version is missing a field on "Interests" in the page view that is in the D6 version.
    • The page style/format for the D6 version is Table and in the D7 version it is grid.
    • There is default sorting in the block view that is not in the D6 version.
oadaeh’s picture

Status: Needs review » Needs work
senpai’s picture

Status: Needs work » Needs review
StatusFileSize
new60.02 KB

This patch builds upon #8 by changing the naming of a role from the incorrect 'administrator' to 'site administrator', which was what @druroot intended in the first place. This change allows the Feature to remain in a default state rather than being overridden.

This patch does not address any of the issues raised by @oadeah in #9

gnuget’s picture

If profile module is not longer available how should get the profile fields like job, interests, first and last name?

Should be add as dependence the profile2 module and use it instead the deprecated one?

gnuget’s picture

Forget my last comment i didn't know to is possible to add fields without any profile module.

I made a new patch who fix all the issues raised by @oadeah in #9

mrconnerton’s picture

Patch #13 looks and works good for me with no relationship on it. Once a decision is made between signup and relation module we can update this patch accordingly

+1 RTBC

ezra-g’s picture

Status: Needs review » Fixed

Awesome - thanks everyone! This is committed.

http://drupalcode.org/project/cod_support.git/commit/22a4db7

Automatically closed -- issue fixed for 2 weeks with no activity.